Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text is stripped/reformatted after pasting to Notes field #1307

Closed
VKondakoff opened this issue Oct 16, 2019 · 6 comments
Closed

Text is stripped/reformatted after pasting to Notes field #1307

VKondakoff opened this issue Oct 16, 2019 · 6 comments
Assignees
Labels
Type ◦ Enhancement Improves an existing feature
Milestone

Comments

@VKondakoff
Copy link

VKondakoff commented Oct 16, 2019

Describe the bug
Text is stripped/reformatted after pasting to Notes field:

Screenshot 2019-10-16 at 12 05 48

(original text in VSCode, resulting text after pasting into Notes field)

This looks quite dangerous to me, because the text copied back from Notes field using Copy button differs from the original.

Here is the original text:

Valery Kondakoff <email@adre.ss>

adress_revoke.asc:

-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: GnuPG v1.2.1 (MingW32)
Comment: A revocation certificate should follow

<text_deleted>
-----END PGP PUBLIC KEY BLOCK-----

Here is the same text after it was pasted to Notes field and copied back:

Valery Kondakoff email@adre.ss

adress_revoke.asc:

-----BEGIN PGP PUBLIC KEY BLOCK----- Version: GnuPG v1.2.1 (MingW32) Comment: A revocation certificate should follow

-----END PGP PUBLIC KEY BLOCK-----

Environment
KeeWeb v1.11.9 (2c9c8b9, 2019-10-13)
Environment: electron v6.0.10
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_0) AppleWebKit/537.36 (KHTML, like Gecko) KeeWeb/1.11.9 Chrome/76.0.3809.146 Electron/6.0.10 Safari/537.36

@VKondakoff
Copy link
Author

VKondakoff commented Oct 16, 2019

Ok, I see - there is markup (?) formatting available in Notes field. Can it be disabled?

@antelle
Copy link
Member

antelle commented Oct 16, 2019

Right, this is Markdown formatting.
Adding an option makes sense, will add it in the next release. This will be a global option indeed, not a per-entry switch.

@antelle antelle added the Type ◦ Enhancement Improves an existing feature label Oct 16, 2019
@antelle antelle added this to the v1.12 milestone Oct 16, 2019
@VKondakoff
Copy link
Author

Thanks, global option is OК.

antelle pushed a commit that referenced this issue Oct 17, 2019
@antelle antelle self-assigned this Oct 17, 2019
@antelle
Copy link
Member

antelle commented Oct 17, 2019

Screen Shot 2019-10-17 at 19 14 00

@VKondakoff
Copy link
Author

Perfect! Thank you!

@antelle
Copy link
Member

antelle commented Oct 17, 2019

Deployed to beta.keeweb.info, will be available in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type ◦ Enhancement Improves an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants