Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

ExpiredMessagesCollectorJob should not contain any SQL #12

Closed
stokito opened this issue Sep 29, 2013 · 1 comment
Closed

ExpiredMessagesCollectorJob should not contain any SQL #12

stokito opened this issue Sep 29, 2013 · 1 comment

Comments

@stokito
Copy link
Contributor

stokito commented Sep 29, 2013

ExpiredMessagesCollectorJob updates AsynchronousMailMessage table.
It looks for me not a good idea. There is a convention that all changes to DB should be done by service.
Could you extract this code to method in AsynchronousMailPersistenceService class?
@stokito
Copy link
Contributor Author

stokito commented Sep 29, 2013

I found your commit 992c06a that fix problem.
Thanks!

@stokito stokito closed this as completed Sep 29, 2013
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stokito