#143 Make Kefir.combine() also accept sources as objects

[32bitkid]

Here is an implementation that enhances the existing combine method to accept objects as well as arrays:

const a = Kefir.sequentially(1000, [1,2,3]), b = Kefir.constant(4);
Kefir.combine({a,b}).log();
// { a: 1, b: 4 }
// { a: 2, b: 4 }
// { a: 3, b: 4 }

Given key conflicts between active and passive observables, it will prefer active ones:

const a = Kefir.sequentially(1000, [1,2,3]), _a = Kefir.constant(4);
Kefir.combine({a}, {a: _a}).log();
// { a: 1 }
// { a: 2 }
// { a: 3 }

Mismatched (array/object) active and passive collections throw an exception.

Kefir.combine({a}, [b]); // error

After thinking about it, I think overloading combine() feels like a more predictable interface for new users and improves code readability. However, I'm open to switch it to its own method (it wouldn't take much abstraction from its current form to do that).

I'll work on updating the documentation if this looks like a good approach/direction.

[rpominov]

Overall everything looks good. I'm happy with how API looks externally, and I only may have some comments on implementation detail when I get a chance to take a closer look.

[aindlq]

Do you still have plans to merge this in? It can be very convenient to use this feature with Mapped Types from the latest Typescript, see microsoft/TypeScript#12114

[rpominov]

Yeah, sorry, I've forgot to give more feedback.

Everything looks good so far, @32bitkid! If you'd like to finish this up, that would be awesome.

[32bitkid]

@rpominov I've been meaning to wrap this up, as well. I took a stab at some documentation, let me know if you need anything else from me to get this merged in.

[rpominov]

Thank you very much for all the work, everything looks great! I'll merge this and release a new version tomorrow.

[rpominov]

Sorry, couldn't do it today. Very busy at work these days. I'll get to this tomorrow or at weekend.

[rpominov]

Merged and released.
Thank you again, and happy 2017!

[32bitkid]

Thank you for all the work you do maintaining kefir. I'm just happy to help. Cheers and happy 2017!

…

On Sat, Dec 31, 2016 at 8:57 AM, Roman Pominov ***@***.***> wrote: Merged and released. Thank you again, and happy 2017! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/rpominov/kefir/pull/225#issuecomment-269870894>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEe3lwmicSJe20rxUtYnjTH1-GsYtnbks5rNntZgaJpZM4Kcp0I> .