♻️ Code refactoring

kefranabg · Jun 8, 2019 · 1ae6c40 · 1ae6c40
1 parent 912c602
commit 1ae6c40
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 33 deletions.
diff --git a/src/cli.js b/src/cli.js
@@ -7,19 +7,7 @@ const boxen = require('boxen')
 const { getProjectInfos } = require('./utils')
 
 const { getTemplate, createReadme } = require('./utils')
-const {
-  askProjectName,
-  askProjectDescription,
-  askAuhtorName,
-  askAuthorGithub,
-  askAuthorTwitter,
-  askLicenseUrl,
-  askContributing,
-  askProjectVersion,
-  askProjectPrerequisites,
-  askLicenseName,
-  askProjectDocumentationUrl
-} = require('./questions')
+const questionsBuilders = require('./questions')
 
 /**
  * Ask user questions and return context to generate a README
@@ -31,22 +19,8 @@ const askQuestions = async projectInfos => {
     projectPrerequisites: undefined
   }
 
-  const questionFns = [
-    askProjectName,
-    askProjectVersion,
-    askProjectDescription,
-    askProjectDocumentationUrl,
-    askAuhtorName,
-    askAuthorGithub,
-    askAuthorTwitter,
-    askProjectPrerequisites,
-    askLicenseName,
-    askLicenseUrl,
-    askContributing
-  ]
-
-  for (const questionFn of questionFns) {
-    const question = questionFn(projectInfos, answersContext)
+  for (const questionBuilder of Object.values(questionsBuilders)) {
+    const question = questionBuilder(projectInfos, answersContext)
 
     if (!isNil(question)) {
       const currentAnswerContext = await inquirer.prompt([question])

diff --git a/src/questions/index.js b/src/questions/index.js
@@ -12,14 +12,14 @@ const askProjectDocumentationUrl = require('./project-documentation-url')
 
 module.exports = {
   askProjectName,
+  askProjectVersion,
   askProjectDescription,
+  askProjectDocumentationUrl,
   askAuhtorName,
   askAuthorGithub,
   askAuthorTwitter,
+  askProjectPrerequisites,
   askLicenseName,
   askLicenseUrl,
-  askContributing,
-  askProjectVersion,
-  askProjectPrerequisites,
-  askProjectDocumentationUrl
+  askContributing
 }