🐛 Don't suggest install default value when project is not a js project (

#169)
kefranabg · Nov 1, 2019 · 672d591 · 672d591
1 parent 5ec2ce4
commit 672d591
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 5 deletions.
diff --git a/src/project-infos.js b/src/project-infos.js
@@ -124,6 +124,7 @@ const getProjectInfos = async () => {
   const spinner = ora('Gathering project infos').start()
 
   const packageJson = await getPackageJson()
+  const isJSProject = !!packageJson
   const name = getProjectName(packageJson)
   const description = get(packageJson, 'description', undefined)
   const engines = get(packageJson, 'engines', undefined)
@@ -169,7 +170,8 @@ const getProjectInfos = async () => {
     documentationUrl,
     isGithubRepos,
     usage,
-    testCommand
+    testCommand,
+    isJSProject
   }
 }
 

diff --git a/src/project-infos.spec.js b/src/project-infos.spec.js
@@ -83,6 +83,7 @@ describe('projectInfos', () => {
         documentationUrl:
           'https://github.com/kefranabg/readme-md-generator#readme',
         isGithubRepos: true,
+        isJSProject: true,
         usage: undefined,
         testCommand: undefined
       })
@@ -134,6 +135,7 @@ describe('projectInfos', () => {
         licenseUrl: undefined,
         documentationUrl: undefined,
         isGithubRepos: false,
+        isJSProject: true,
         usage: undefined,
         testCommand: undefined
       })
@@ -165,6 +167,7 @@ describe('projectInfos', () => {
         documentationUrl:
           'https://github.com/kefranabg/readme-md-generator#readme',
         isGithubRepos: true,
+        isJSProject: false,
         usage: undefined,
         testCommand: undefined
       })
@@ -193,6 +196,7 @@ describe('projectInfos', () => {
         licenseUrl: undefined,
         documentationUrl: undefined,
         isGithubRepos: false,
+        isJSProject: false,
         usage: undefined,
         testCommand: undefined
       })
@@ -221,6 +225,7 @@ describe('projectInfos', () => {
         licenseUrl: undefined,
         documentationUrl: undefined,
         isGithubRepos: false,
+        isJSProject: false,
         usage: undefined,
         testCommand: undefined
       })
@@ -274,6 +279,7 @@ describe('projectInfos', () => {
         documentationUrl:
           'https://github.com/kefranabg/readme-md-generator#readme',
         isGithubRepos: true,
+        isJSProject: true,
         usage: undefined,
         testCommand: undefined
       })
@@ -331,6 +337,7 @@ describe('projectInfos', () => {
         documentationUrl:
           'https://github.com/kefranabg/readme-md-generator#readme',
         isGithubRepos: true,
+        isJSProject: true,
         usage: undefined,
         testCommand: undefined
       })

diff --git a/src/questions/install-command.js b/src/questions/install-command.js
@@ -1,6 +1,6 @@
-module.exports = () => ({
+module.exports = projectInfos => ({
   type: 'input',
   message: '📦  Install command (use empty value to skip)',
   name: 'installCommand',
-  default: 'npm install'
+  default: projectInfos.isJSProject ? 'npm install' : undefined
 })
diff --git a/src/questions/install-command.spec.js b/src/questions/install-command.spec.js
@@ -1,8 +1,9 @@
 const askInstallCommand = require('./install-command')
 
 describe('askInstallCommand', () => {
-  it('should return correct question format', () => {
-    const result = askInstallCommand()
+  it('should return correct question format when project lang is js', () => {
+    const projectInfos = { isJSProject: true }
+    const result = askInstallCommand(projectInfos)
 
     expect(result).toEqual({
       type: 'input',
@@ -11,4 +12,16 @@ describe('askInstallCommand', () => {
       default: 'npm install'
     })
   })
+
+  it('should return correct question format when project lang is js', () => {
+    const projectInfos = { isJSProject: false }
+    const result = askInstallCommand(projectInfos)
+
+    expect(result).toEqual({
+      type: 'input',
+      message: '📦  Install command (use empty value to skip)',
+      name: 'installCommand',
+      default: undefined
+    })
+  })
 })