Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log CombinedOutput instead of just Output #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Log CombinedOutput instead of just Output #3

wants to merge 1 commit into from

Conversation

maddie
Copy link

@maddie maddie commented Nov 7, 2016

Output() only shows the messages written to stdout but not stderr.
Switching to CombinedOutput() would log both stdout and stderr to
result.Error.CmdOutput.

@maddie
Log CombinedOutput instead of just Output
13ada9c 
`Output()` only shows the messages written to `stdout` but not `stderr`.
Switching to `CombinedOutput()` would log both `stdout` and `stderr` to
`result.Error.CmdOutput`.
@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 96.774% when pulling 13ada9c on maddie:master into 40c7487 on keighl:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maddie @coveralls