Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Streak glitch by Unlit shaders #5

Closed
stencg opened this issue Jan 24, 2019 · 6 comments
Closed

[Android] Streak glitch by Unlit shaders #5

stencg opened this issue Jan 24, 2019 · 6 comments
Assignees
Labels
question Further information is requested

Comments

@stencg
Copy link

stencg commented Jan 24, 2019

Any Unlit/... shaders give overbright for Streak. Test in 2018.3.0f2
More info in screenshots
https://prnt.sc/mbj7dq - in editor (work fine)
https://prnt.sc/mbj6vs - in game (have glitch)

p.s.
UI image with full black color too impact Streak fx, if canvas render mode - World Space

@keijiro keijiro self-assigned this Jan 24, 2019
@keijiro keijiro added the question Further information is requested label Jan 24, 2019
@keijiro
Copy link
Owner

keijiro commented Jan 24, 2019

Thank you for reporting the issue. Could you provide additional information on it?

  • According to the screenshot, this issue was observed on Xiaomi Mi 5s. Is it right?
  • Can you reproduce the same issue on other devices?

@stencg
Copy link
Author

stencg commented Jan 24, 2019

Yes Mi 5s. And yes, reproduced on other devices, but only with GPU Adreno. No problem with Mali (PowerVR I will test later).
I also found that a problem occurs when there are completely black pixels in the texture.

@keijiro
Copy link
Owner

keijiro commented Jan 25, 2019

Thanks for the information. It helps me a lot. I'll test it on a device later.

@keijiro
Copy link
Owner

keijiro commented Oct 5, 2019

The situation changed in the recent several months -- The post processing stack was deprecated and replaced with built-in post processing effects in the each render pipeline (URP and HDRP). Following this move, I changed the focus of this project to support only HDRP.

I'd like to start another project to support URP when custom effect support is added to it (at the moment URP doesn't support custom post processing effects).

@keijiro keijiro closed this as completed Oct 5, 2019
@andybak
Copy link

andybak commented Oct 5, 2019

at the moment URP doesn't support custom post processing effects)

I was wondering about this. As a workaround could you use ScriptableRenderPasses as a workaround for the lack of custom post-processing?

@keijiro
Copy link
Owner

keijiro commented Oct 5, 2019

I think it's better to wait for post processing support. I don't like to rewrite all the things twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants