Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade kubernetes dependencies to support upto k8s 1.25 #146

Merged
merged 6 commits into from Sep 21, 2023

Conversation

rkilingr
Copy link
Contributor

@rkilingr rkilingr commented Jul 20, 2023

Fixes issue #145

Proposed Changes

  • Upgrade controller-runtime to v0.13.1
  • Upgrade k8s dependencies to version v0.25.12

Testing Done

  • Manual Testing: ✅
image
  • Ignore the coverage decrease, as no new code lines were added Fixed Test Coverage ✅

Signed-off-by: RaviKiran Kilingar <ravikirankilingar@gmail.com>
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #146 (fcf9c3b) into master (5487edb) will increase coverage by 0.75%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   66.46%   67.22%   +0.75%     
==========================================
  Files           3        3              
  Lines        1142     1141       -1     
==========================================
+ Hits          759      767       +8     
+ Misses        303      296       -7     
+ Partials       80       78       -2     
Files Changed Coverage Δ
metrics/collector.go 74.28% <ø> (ø)
controllers/healthcheck_controller.go 67.05% <100.00%> (+0.78%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tekenstam
Copy link
Member

@rkilingr Is this PR ready to merge?

@rkilingr
Copy link
Contributor Author

@rkilingr Is this PR ready to merge?

Hey, Sorry lost sight of this PR. Have attached test results by testing one of the examples, working fine ✅

Signed-off-by: RaviKiran Kilingar <ravikirankilingar@gmail.com>
@rkilingr rkilingr mentioned this pull request Sep 21, 2023
@rkilingr rkilingr marked this pull request as ready for review September 21, 2023 11:53
@rkilingr rkilingr requested a review from a team as a code owner September 21, 2023 11:53
Signed-off-by: RaviKiran Kilingar <ravikirankilingar@gmail.com>
@rkilingr rkilingr marked this pull request as draft September 21, 2023 14:12
@rkilingr
Copy link
Contributor Author

Checking why tests aren't getting triggered

Signed-off-by: RaviKiran Kilingar <ravikirankilingar@gmail.com>
@rkilingr rkilingr marked this pull request as ready for review September 21, 2023 15:36
@rkilingr
Copy link
Contributor Author

Checking why tests aren't getting triggered

Fixed it

@RaviHari RaviHari merged commit 621cafb into keikoproj:master Sep 21, 2023
4 checks passed
@rkilingr rkilingr deleted the upgrade-client-go-version branch September 21, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants