Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

githubactions for unit tests, docker image build & push #95

Merged
merged 4 commits into from Jun 1, 2021

Conversation

RaviHari
Copy link
Collaborator

Fixes issue #81

Proposed Changes

  • Githubactions for Active-Monitor

@RaviHari RaviHari requested a review from a team as a code owner May 31, 2021 11:59
Signed-off-by: Ravi Hari <ravireliable@gmail.com>
This reverts commit 21647e0.

Signed-off-by: Ravi Hari <ravireliable@gmail.com>
Signed-off-by: Ravi Hari <ravireliable@gmail.com>
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #95 (a1cb673) into master (4675309) will decrease coverage by 0.81%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   61.33%   60.51%   -0.82%     
==========================================
  Files           3        3              
  Lines         856      856              
==========================================
- Hits          525      518       -7     
- Misses        246      252       +6     
- Partials       85       86       +1     
Impacted Files Coverage Δ
controllers/healthcheck_controller.go 60.14% <0.00%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4675309...a1cb673. Read the comment docs.

Signed-off-by: Ravi Hari <ravireliable@gmail.com>
Copy link

@shaoxt shaoxt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RaviHari RaviHari merged commit 40ac8e4 into keikoproj:master Jun 1, 2021
RaviHari added a commit that referenced this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants