Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unjoined instance scanning #17

Merged
merged 2 commits into from
Sep 30, 2019

Conversation

eytan-avisror
Copy link
Collaborator

Fixes #16

@eytan-avisror eytan-avisror requested a review from a team as a code owner September 30, 2019 23:47
Copy link

@vgunapati vgunapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

Merging #17 into master will increase coverage by 0.1%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #17     +/-   ##
=========================================
+ Coverage   53.28%   53.38%   +0.1%     
=========================================
  Files           4        4             
  Lines         822      826      +4     
=========================================
+ Hits          438      441      +3     
- Misses        337      338      +1     
  Partials       47       47
Impacted Files Coverage Δ
pkg/reaper/nodereaper/nodereaper.go 46.79% <75%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e8815f...22e8b3a. Read the comment docs.

@eytan-avisror eytan-avisror merged commit ca4a768 into keikoproj:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reap Unjoined discovers terminated instances
2 participants