Migrate to modules

[matt0x6F]

Closes #18

[CLAassistant]

All committers have signed the CLA.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@ca4a768). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #19   +/-   ##
=========================================
  Coverage          ?   53.38%           
=========================================
  Files             ?        4           
  Lines             ?      826           
  Branches          ?        0           
=========================================
  Hits              ?      441           
  Misses            ?      338           
  Partials          ?       47

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca4a768...e5a42f1. Read the comment docs.

[eytan-avisror]

Hi @mattouille
Looks like you 'added' modules, but didn't remove deps, make sure to also run go mod tidy & go mod vendor to verify it doesn't try to change dependencies.

Can you also do a basic functional test with make docker-build and try to run both reapers locally?

[matt0x6F]

I was able to verify the run with make docker-build. The vendor directory won't be 1:1 because they track dependencies slightly differently.

[eytan-avisror]

Hi @mattouille
Thanks! it looks good, but can you also test running the packages?
See https://github.com/keikoproj/governor/blob/master/.github/DEVELOPER.md for more info

[matt0x6F]

=== RUN   TestGetUnreadyNodesPositive
--- PASS: TestGetUnreadyNodesPositive (0.00s)
=== RUN   TestGetUnreadyNodesNegative
--- PASS: TestGetUnreadyNodesNegative (0.00s)
=== RUN   TestReapOldPositive
--- PASS: TestReapOldPositive (0.01s)
=== RUN   TestReapOldNegative
--- PASS: TestReapOldNegative (0.00s)
=== RUN   TestReapOldDisabled
--- PASS: TestReapOldDisabled (0.00s)
=== RUN   TestReapOldSelfEviction
--- PASS: TestReapOldSelfEviction (0.00s)
=== RUN   TestReapUnknownPositive
--- PASS: TestReapUnknownPositive (0.00s)
=== RUN   TestReapUnknownNegative
--- PASS: TestReapUnknownNegative (0.00s)
=== RUN   TestReapUnreadyPositive
--- PASS: TestReapUnreadyPositive (0.00s)
=== RUN   TestReapUnreadyNegative
--- PASS: TestReapUnreadyNegative (0.00s)
=== RUN   TestFlapDetectionPositive
--- PASS: TestFlapDetectionPositive (0.00s)
=== RUN   TestFlapDetectionNegative
--- PASS: TestFlapDetectionNegative (0.00s)
=== RUN   TestAsgValidationPositive
--- PASS: TestAsgValidationPositive (0.00s)
=== RUN   TestAsgValidationNegative
--- PASS: TestAsgValidationNegative (0.00s)
=== RUN   TestSoftReapPositive
--- PASS: TestSoftReapPositive (0.00s)
=== RUN   TestSoftReapNegative
--- PASS: TestSoftReapNegative (0.00s)
=== RUN   TestReapThrottleWaiter
--- PASS: TestReapThrottleWaiter (2.00s)
=== RUN   TestAgeReapThrottleWaiter
--- PASS: TestAgeReapThrottleWaiter (2.02s)
=== RUN   TestDryRun
--- PASS: TestDryRun (0.00s)
=== RUN   TestKillOldMasterMinMasters
--- PASS: TestKillOldMasterMinMasters (0.00s)
=== RUN   TestMaxKill
--- PASS: TestMaxKill (0.00s)
=== RUN   TestUnjoinedPositive
--- PASS: TestUnjoinedPositive (0.00s)
=== RUN   TestUnjoinedNegative
--- PASS: TestUnjoinedNegative (0.00s)
=== RUN   TestGhostPositive
--- PASS: TestGhostPositive (0.00s)
=== RUN   TestProviderIDParser
--- PASS: TestProviderIDParser (0.00s)
PASS
coverage: 56.2% of statements
ok  	github.com/keikoproj/governor/pkg/reaper/nodereaper	5.045s	coverage: 56.2% of statements
=== RUN   TestDeriveStatePositive
--- PASS: TestDeriveStatePositive (0.00s)
=== RUN   TestDeriveStateNegative
--- PASS: TestDeriveStateNegative (0.00s)
=== RUN   TestDeriveTimeReapablePositive
--- PASS: TestDeriveTimeReapablePositive (0.00s)
=== RUN   TestDeriveTimeReapableNegative
--- PASS: TestDeriveTimeReapableNegative (0.00s)
=== RUN   TestDryRunPositive
--- PASS: TestDryRunPositive (0.00s)
=== RUN   TestSoftReapPositive
--- PASS: TestSoftReapPositive (0.00s)
=== RUN   TestSoftReapNegative
--- PASS: TestSoftReapNegative (0.00s)
=== RUN   TestValidateArgumentsPositive
--- PASS: TestValidateArgumentsPositive (0.00s)
=== RUN   TestValidateArgumentsNegative
--- PASS: TestValidateArgumentsNegative (0.00s)
PASS
coverage: 65.8% of statements
ok  	github.com/keikoproj/governor/pkg/reaper/podreaper	0.703s	coverage: 65.8% of statements

[eytan-avisror]

LGTM