Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate terminating nodes #25

Merged
merged 3 commits into from
Feb 18, 2020

Conversation

eytan-avisror
Copy link
Collaborator

Fixes #24

This adds an annotate with key governor.keikoproj.io/terminating: "true" prior to issuing a terminate.

@eytan-avisror eytan-avisror requested review from wanghong230 and a team February 14, 2020 21:22
@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #25 into master will increase coverage by 1.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   55.42%   56.48%   +1.06%     
==========================================
  Files           4        4              
  Lines         821      825       +4     
==========================================
+ Hits          455      466      +11     
+ Misses        317      304      -13     
- Partials       49       55       +6
Impacted Files Coverage Δ
pkg/reaper/nodereaper/nodereaper.go 46.38% <0%> (-0.41%) ⬇️
pkg/reaper/nodereaper/helpers.go 63.24% <0%> (+4.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b5d58b...e0166de. Read the comment docs.

@eytan-avisror eytan-avisror merged commit 621296b into keikoproj:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node Reaper - annotate nodes being terminated
2 participants