Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State annotations #26

Merged
merged 2 commits into from
Feb 19, 2020
Merged

Conversation

eytan-avisror
Copy link
Collaborator

Improved the implementation in #24

Node will be annotated with governor.keikoproj.io/state: draining before drain is executed.
Node will be annotated with governor.keikoproj.io/state: termination-issued after termination API is called.

@eytan-avisror eytan-avisror requested a review from a team as a code owner February 19, 2020 18:33
@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is 60%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   56.48%   56.48%           
=======================================
  Files           4        4           
  Lines         825      825           
=======================================
  Hits          466      466           
  Misses        304      304           
  Partials       55       55
Impacted Files Coverage Δ
pkg/reaper/nodereaper/nodereaper.go 46.79% <100%> (+0.4%) ⬆️
pkg/reaper/nodereaper/helpers.go 62.18% <53.84%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 621296b...8cc28e9. Read the comment docs.

@eytan-avisror eytan-avisror merged commit 3ced477 into keikoproj:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants