Failed / Completed pod support #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 56.48% 59.10% +2.62%
==========================================
Files 4 5 +1
Lines 825 939 +114
==========================================
+ Hits 466 555 +89
- Misses 304 319 +15
- Partials 55 65 +10
Continue to review full report at Codecov.
|
shrinandj
approved these changes
Apr 16, 2020
eytan-avisror
added a commit
to eytan-avisror/governor
that referenced
this pull request
Apr 16, 2020
* initial implementation * fixes * Namespace exclusion * test sorting * test fixes * exclusion granularity * add vendor dependencies * fixes * Update podreaper.go * Update README.md * Update README.md * Update README.md * add namespaces rbac * fix readme typos
vgunapati
reviewed
Apr 17, 2020
| |---|:---:|:---:| | ||
| | governor.keikoproj.io/disable-pod-reaper | "true" | disable all features | ||
| | governor.keikoproj.io/disable-completed-pod-reap | "true" | disable completed pod reaping | ||
| | governor.keikoproj.io/disable-completed-pod-reap | "true" | disable failed pod reaping |
There was a problem hiding this comment.
this should be governor.keikoproj.io/disable-failed-pod-reap ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
Fixes #28