reap evicted pods #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
==========================================
+ Coverage 59.19% 59.49% +0.29%
==========================================
Files 5 5
Lines 941 943 +2
==========================================
+ Hits 557 561 +4
+ Misses 319 318 -1
+ Partials 65 64 -1
Continue to review full report at Codecov.
|
shrinandj
approved these changes
Jul 23, 2020
viveksyngh
pushed a commit
to viveksyngh/governor
that referenced
this pull request
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
This fixes a bug where we don't properly reap evicted pods.
This change ignores
--reap-failed-afterflag, if there are no containerstatuses in the failed pod, and proceeds to mark it reapable essentially ignoring that flag.