Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reap tainted nodes #35

Merged
merged 3 commits into from
Jul 28, 2020

Conversation

eytan-avisror
Copy link
Collaborator

This adds the ability to make nodes with certain taints reapable.

@eytan-avisror eytan-avisror requested a review from a team as a code owner July 27, 2020 21:43
@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #35 into master will increase coverage by 0.92%.
The diff coverage is 76.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   59.49%   60.42%   +0.92%     
==========================================
  Files           5        5              
  Lines         943      998      +55     
==========================================
+ Hits          561      603      +42     
- Misses        318      331      +13     
  Partials       64       64              
Impacted Files Coverage Δ
pkg/reaper/nodereaper/types.go 100.00% <ø> (ø)
pkg/reaper/nodereaper/nodereaper.go 47.84% <61.11%> (+0.81%) ⬆️
pkg/reaper/nodereaper/helpers.go 65.51% <100.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d02bed...63cc5ea. Read the comment docs.

@eytan-avisror eytan-avisror merged commit 84d1d6e into keikoproj:master Jul 28, 2020
viveksyngh pushed a commit to viveksyngh/governor that referenced this pull request Oct 27, 2020
* Reap nodes with taint

* Update README.md

* refactor (coverage)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants