Update aws-sdk-go to support IRSA #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=======================================
Coverage 60.42% 60.42%
=======================================
Files 5 5
Lines 998 998
=======================================
Hits 603 603
Misses 331 331
Partials 64 64 Continue to review full report at Codecov.
|
|
Can we get rid of vendor/ all together and switch to go-mod while you are making this change? |
viveksyngh
pushed a commit
to viveksyngh/governor
that referenced
this pull request
Oct 27, 2020
* update aws sdk to support irsa * remove vendor and use modules * run with modules on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36
Changes:
Updates the version of aws-sdk-go from v1.16.26 to v1.32.4 to allow support for IRSA
Removes
vendor/and uses go modulesTesting Done: