Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider unreapable nodes after specified time #44

Merged

Conversation

viveksyngh
Copy link
Contributor

  • Add flag --reconsider-unreapable-node with default value 10 mins
  • When a node drain failed, set the current time to governor.keikoproj.io/age-unreapable annotation
  • Backward compatibility with previous value for the annotation

Fixes: #39

@viveksyngh viveksyngh requested a review from a team as a code owner November 12, 2020 18:25
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@viveksyngh
Copy link
Contributor Author

@eytan-avisror looks like CLA is not removed yet, could you please check ?

@eytan-avisror
Copy link
Collaborator

@viveksyngh I removed it now, but it's still shows pending for some reason.
I will force merge this once the CI passes.

- Add flag `--reconsider-unreapable-node` with default value 10 mins
- When a node drain failed, set the current time to `governor.keikoproj.io/age-unreapable` annotation
- Backward compatibility with previous value for the annotation

Fixes: keikoproj#39
Signed-off-by: Vivek Singh <svivekkumar@vmware.com>
Copy link
Collaborator

@eytan-avisror eytan-avisror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #44 (590dd27) into master (926911b) will decrease coverage by 3.23%.
The diff coverage is 68.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   60.42%   57.18%   -3.24%     
==========================================
  Files           5        5              
  Lines         998      918      -80     
==========================================
- Hits          603      525      -78     
+ Misses        331      330       -1     
+ Partials       64       63       -1     
Impacted Files Coverage Δ
pkg/reaper/nodereaper/helpers.go 60.88% <0.00%> (-4.63%) ⬇️
pkg/reaper/nodereaper/types.go 100.00% <ø> (ø)
pkg/reaper/nodereaper/nodereaper.go 46.07% <73.91%> (-1.78%) ⬇️
pkg/reaper/podreaper/podreaper.go 75.59% <0.00%> (-2.23%) ⬇️
pkg/reaper/podreaper/types.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 926911b...590dd27. Read the comment docs.

@eytan-avisror eytan-avisror merged commit c4aa4b4 into keikoproj:master Nov 12, 2020
shaoxt pushed a commit to shaoxt/governor that referenced this pull request Dec 21, 2021
- Add flag `--reconsider-unreapable-node` with default value 10 mins
- When a node drain failed, set the current time to `governor.keikoproj.io/age-unreapable` annotation
- Backward compatibility with previous value for the annotation

Fixes: keikoproj#39
Signed-off-by: Vivek Singh <svivekkumar@vmware.com>
Signed-off-by: shaoxt <shaoxt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node reaper not reaping aged nodes again which are failed to drain once.
3 participants