-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconsider unreapable nodes after specified time #44
Reconsider unreapable nodes after specified time #44
Conversation
|
1d1751c
to
b7bfa36
Compare
@eytan-avisror looks like CLA is not removed yet, could you please check ? |
@viveksyngh I removed it now, but it's still shows pending for some reason. |
- Add flag `--reconsider-unreapable-node` with default value 10 mins - When a node drain failed, set the current time to `governor.keikoproj.io/age-unreapable` annotation - Backward compatibility with previous value for the annotation Fixes: keikoproj#39 Signed-off-by: Vivek Singh <svivekkumar@vmware.com>
b7bfa36
to
590dd27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥇
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
- Coverage 60.42% 57.18% -3.24%
==========================================
Files 5 5
Lines 998 918 -80
==========================================
- Hits 603 525 -78
+ Misses 331 330 -1
+ Partials 64 63 -1
Continue to review full report at Codecov.
|
- Add flag `--reconsider-unreapable-node` with default value 10 mins - When a node drain failed, set the current time to `governor.keikoproj.io/age-unreapable` annotation - Backward compatibility with previous value for the annotation Fixes: keikoproj#39 Signed-off-by: Vivek Singh <svivekkumar@vmware.com> Signed-off-by: shaoxt <shaoxt@gmail.com>
--reconsider-unreapable-node
with default value 10 minsgovernor.keikoproj.io/age-unreapable
annotationFixes: #39