Refactor ReapableInstances to avoid ASG Validation selectively #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 16, 2021 16:01
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 57.81% 58.26% +0.44%
==========================================
Files 7 7
Lines 1183 1198 +15
==========================================
+ Hits 684 698 +14
- Misses 416 417 +1
Partials 83 83
Continue to review full report at Codecov.
|
shaoxt
pushed a commit
to shaoxt/governor
that referenced
this pull request
Dec 21, 2021
* refactor Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com> * Update nodereaper.go Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com> Signed-off-by: shaoxt <shaoxt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eytan Avisror eytan_avisror@intuit.com
Fixes #51
This refactor ReapableInstances into a structured object instead of a map, which allows to select if a specific instance requires ASG validation.
With this change, even if ASG Validation is on, unjoined nodes will be terminated.