Add NAT AZ Cordon tool #56
Conversation
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 58.26% 59.71% +1.44%
==========================================
Files 7 9 +2
Lines 1198 1390 +192
==========================================
+ Hits 698 830 +132
- Misses 417 467 +50
- Partials 83 93 +10
Continue to review full report at Codecov.
|
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
…o az-nat-cordon Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com>
| for _, r := range routes { | ||
| if restore { | ||
| if gws, ok := zoneMap[r.ZoneID]; ok { | ||
| r.NewGateway = gws[0] |
There was a problem hiding this comment.
What if there are multiple NATs in the same AZ? Could the original NAT be remembered by adding a tag? If a different NAT is restored than what was used originally then perhaps dependencies that whitelist a specific NAT IP will be broken? Perhaps this can be done as a followup feature?
There was a problem hiding this comment.
Technically there is no difference between one NAT and another as long as they are in the same zone and are both healthy, hence we just chose one of existing NATs under that scope.
We can add tagging, but I am not sure there are use cases where that matters
* az cordon tool Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com> * fixes and unit tests Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com> * documentation & fixes Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com> * remove comments / newlines Signed-off-by: Eytan Avisror <eytan_avisror@intuit.com> Signed-off-by: shaoxt <shaoxt@gmail.com>
No description provided.