add not-ready reap logic and unit test #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahilbadla
force-pushed
the
reap-not-ready
branch
from
4c6aa3b
to
b93cb14
Compare
tekenstam
reviewed
Oct 21, 2021
pkg/reaper/pdbreaper/pdbreaper.go
Outdated
Comment on lines
434
to
439
| if pod.Status.Phase == corev1.PodPending && isPodReadinessThresholdPast(pod.Status.StartTime, thresholdSeconds) { | ||
| notReadyCount++ | ||
| } | ||
|
|
||
| if pod.Status.Phase == corev1.PodRunning && isPodReadinessThresholdPast(pod.Status.StartTime, thresholdSeconds) { | ||
| for _, condition := range pod.Status.Conditions { | ||
| if condition.Type == "ContainersReady" && condition.Status == "False" { | ||
| notReadyCount++ | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Instead of pod.Status.StartTime, (which is the start of the Pod) would it be possible to check if the threshold is past when the container last entered the NotReady state? For example, the lastTransitionTime of the Ready or ContainersReady condition?
status:
conditions:
- lastProbeTime: null
lastTransitionTime: "2021-09-15T22:27:29Z"
status: "True"
type: Initialized
- lastProbeTime: null
lastTransitionTime: "2021-09-15T22:27:15Z"
message: 'containers with unready status: [app]'
reason: ContainersNotReady
status: "False"
type: Ready
- lastProbeTime: null
lastTransitionTime: "2021-09-15T22:27:15Z"
message: 'containers with unready status: [app]'
reason: ContainersNotReady
status: "False"
type: ContainersReady
- lastProbeTime: null
lastTransitionTime: "2021-09-15T22:27:15Z"
status: "True"
type: PodScheduled
tekenstam
reviewed
Oct 21, 2021
cmd/governor/app/pdbreaper.go
Outdated
| @@ -49,4 +49,7 @@ func init() { | |||
| pdbReaperCmd.Flags().BoolVar(&pdbReaperArgs.AllCrashLoop, "all-crashloop", true, "Only deletes PDBs for crashlooping pods when all pods are in crashloop") | |||
| pdbReaperCmd.Flags().IntVar(&pdbReaperArgs.CrashLoopRestartCount, "crashloop-restart-count", 5, "Minimum restart count to when considering pods in crashloop") | |||
| pdbReaperCmd.Flags().StringSliceVar(&pdbReaperArgs.ExcludedNamespaces, "excluded-namespaces", []string{}, "Namespaces excluded from scanning") | |||
| pdbReaperCmd.Flags().BoolVar(&pdbReaperArgs.ReapNotReady, "reap-not-ready", true, "Deletes PDBs which have pods in not-ready state") | |||
| pdbReaperCmd.Flags().IntVar(&pdbReaperArgs.ReapNotReadyThreshold, "not-ready-threshold-seconds", 400, "Minimum seconds to wait when considering pods in not-ready state") | |||
There was a problem hiding this comment.
I think the default threshold for deleting a NotReady PDB should probably match the upgrade-manager drainTimeout default, which is 1800 seconds (30 minutes). If a Pod is still not ready after 30 minutes then probably something is wrong. After 400 seconds (6.6 minutes) maybe something is wrong, but there may be cases where containers take longer than 6.6 minutes to start.
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
Signed-off-by: sbadla1 <sahil_badla@intuit.com>
sahilbadla
force-pushed
the
reap-not-ready
branch
from
e8b39d1
to
added1e
Compare
tekenstam
approved these changes
Oct 22, 2021
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 59.71% 59.85% +0.14%
==========================================
Files 9 9
Lines 1390 1420 +30
==========================================
+ Hits 830 850 +20
- Misses 467 476 +9
- Partials 93 94 +1
Continue to review full report at Codecov.
|
shaoxt
pushed a commit
to shaoxt/governor
that referenced
this pull request
Dec 21, 2021
* add not-ready reap logic and unit test Signed-off-by: sbadla1 <sahil_badla@intuit.com> Signed-off-by: shaoxt <shaoxt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pdb-reaper not deleting the pdb's where pods are not fully ready(pod(s) in pending state or pod containers in not ready state)
Changes: