Pull region from node labels if well known label is present #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Back <jonah@jonahback.com>
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 59.85% 60.00% +0.14%
==========================================
Files 9 9
Lines 1420 1425 +5
==========================================
+ Hits 850 855 +5
Misses 476 476
Partials 94 94
Continue to review full report at Codecov.
|
|
Hey @eytan-avisror - mind taking a look at this? |
shailshah9
pushed a commit
to shailshah9/governor
that referenced
this pull request
Nov 8, 2021
…koproj#59) Signed-off-by: Jonah Back <jonah@jonahback.com> Signed-off-by: shailshah9 <shailshah9@gmail.com>
shaoxt
pushed a commit
to shaoxt/governor
that referenced
this pull request
Dec 21, 2021
…koproj#59) Signed-off-by: Jonah Back <jonah@jonahback.com> Signed-off-by: shaoxt <shaoxt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use region value from well known labels if present.
The current region detection from node provider assumes that zones always follow a similar format to
us-west-2a, but this is not the case.Our local zones, which have a zone id of
us-west-2-lax1a, are currently getting parsed with 'us-west-2-lax1` as the region, which is incorrect. Switching to the cloud-provider managed field here should generally be higher fidelity.Signed-off-by: Jonah Back jonah@jonahback.com