Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PDB Reaper metrics for the following values #65

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Fix PDB Reaper metrics for the following values #65

merged 2 commits into from
Mar 14, 2022

Conversation

shaoxt
Copy link
Contributor

@shaoxt shaoxt commented Mar 14, 2022

BlockingPodDisruptionBudgetWithCrashLoop
BlockingPodDisruptionBudgetWithNotReadyState

@shaoxt
Merge pull request #1 from keikoproj/master
7d88404 
Merge back to my fork
@shaoxt
Fix PDB Reaper metrics
0ed55a4 
Signed-off-by: shaoxt <shaoxt@gmail.com>
@shaoxt shaoxt requested a review from a team as a code owner March 14, 2022 20:33
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #65 (0ed55a4) into master (f9369ac) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   59.66%   59.76%   +0.10%     
==========================================
  Files          11       11              
  Lines        1537     1541       +4     
==========================================
+ Hits          917      921       +4     
  Misses        524      524              
  Partials       96       96
Impacted Files Coverage Δ
pkg/reaper/pdbreaper/pdbreaper.go 70.35% <100.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9369ac...0ed55a4. Read the comment docs.

@eytan-avisror eytan-avisror merged commit 6a38e80 into keikoproj:master Mar 14, 2022
MarkSRobinson pushed a commit to MarkSRobinson/governor that referenced this pull request May 30, 2022
@shaoxt @MarkSRobinson
fix: PDB Reaper metrics not sent correctly (keikoproj#65)
bd29684 
Signed-off-by: shaoxt <shaoxt@gmail.com>
Signed-off-by: Mark Robinson <mrobinson@plaid.com>
MarkSRobinson pushed a commit to MarkSRobinson/governor that referenced this pull request May 30, 2022
@shaoxt @MarkSRobinson
fix: PDB Reaper metrics not sent correctly (keikoproj#65)
bad20be 
Signed-off-by: shaoxt <shaoxt@gmail.com>
Signed-off-by: Mark Robinson <mrobinson@plaid.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eytan-avisror eytan-avisror eytan-avisror approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shaoxt @eytan-avisror