Include tests in PyPI tarball #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, Could you help me understand what the specific use you have this? In general this not a very common practice and including it in the manifest like this don't mean it will get installed with pip so you wouldn't really see this file anyway. That may be a good thing though as this is packaged as a plain module and the tests would be another top-level module which is kinda silly. |
|
My specific use case is for packaging into NixOS. For now I used the GitHub URL, but a PyPI URL would be more stable as it doesn't include a username. |
|
hmm ok, makes sense |
|
Thanks for the PR, new tarball with tests included published as version 1.0.1 |
|
Thanks ! |
dannywillems
pushed a commit
to dannywillems/base58
that referenced
this pull request
Mar 12, 2019
Include tests in PyPI tarball
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This e.g. allows downstream distributions to use your test suite as integration tests.
Fixes #32