-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance/add alphabet param #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the PR @dannywillems A few minor nitpicks that it would be great if you could fix but otherwise looks good.
|
b591c68
to
5890144
Compare
Conflict between pytest-cov and coverage packages
Add also a test to check the alias is correct
Use pypy2.7-6.0 and pypy3.5-6.0
5890144
to
e2f8dbc
Compare
Thanks! (Sorry for not getting around to this earlier for some reason github doesn't notify on code updates to PRs ...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to specify different alphabet in the functions to include, for example, the ripple base58 alphabet: https://developers.ripple.com/base58-encodings.html
I also renamed for more clarity the
alphabet
module variable inBITCOIN_ALPHABET
, and add the ripple alphabet too.I suggest to update the version to 1.1.0 as it could break if people uses
base58.alphabet