ignore rename events from fs.watch #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keis
force-pushed
the
rename
branch
4 times, most recently
from
5f7e31b
to
db59278
Compare
keis
force-pushed
the
rename
branch
4 times, most recently
from
18a5711
to
d0b9a55
Compare
To avoid trying to read a file after receiving the event notifying it was removed anything other than 'change' from fs.watch does not start a new read. The cached data is still invalidated as usual though.
On slower machines (such as the tests slaves of travis) the debounce will sometimes not reduce all events of a unlink to one call. This is can lead to weird effects as the first event is a 'change' which triggers an unexpected read. For now force a longer debounce when running tests
keis
added a commit
that referenced
this pull request
Apr 15, 2015
ignore rename events from fs.watch
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just ignoring the renames seems to be a pretty sane thing for now.
ping @JoakimLofgren