Skip to content

Commit

Permalink
Fixes issues / #53
Browse files Browse the repository at this point in the history
  • Loading branch information
keisen committed May 20, 2021
1 parent 08a9415 commit 25d0b3b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,14 @@ jobs:
matrix:
python-version: [3.6, 3.7, 3.8]
tensorflow: [2.0.4, 2.1.3, 2.2.2, 2.3.2, 2.4.1, 2.5.0]
include:
- python-version: 3.9
tensorflow: 2.5.0
exclude:
- python-version: 3.8
tensorflow: 2.0.4
- python-version: 3.8
tensorflow: 2.1.3

steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ matrix.python-version }}
Expand Down
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ The images above are generated by `SmoothGrad`.

## Requirements

* Python 3.6-3.8
* Python 3.6-3.9
* tensorflow>=2.0.2


Expand All @@ -74,7 +74,7 @@ $ docker run --gpus all --privileged -itd -p 8888:8888 <TAG>
Or

```bash
$ docker run --gpus all --privileged -itd -p 8888:8888 keisen/tf-keras-vis:0.6.0-gpu
$ docker run --gpus all --privileged -itd -p 8888:8888 keisen/tf-keras-vis:0.5.0-gpu
```

> You can find other images at [Docker Hub](https://hub.docker.com/repository/docker/keisen/tf-keras-vis/tags).
Expand Down Expand Up @@ -120,6 +120,8 @@ But please note that tf-keras-vis APIs does NOT have compatibility with keras-vi
* With InceptionV3, ActivationMaximization doesn't work well, that's, it might generate meaninglessly blur image.
* With cascading model, Gradcam and Gradcam++ don't work well, that's, it might occur some error. So we recommend, in this case, to use FasterScoreCAM.
* `channels-first` models and data is unsupported.
* With a `mixed-precision` model that has a layer which are set float32 dtype exlicitly, ActivationMaximization may raise a error.

This comment has been minimized.

Copy link
@bersbersbers

bersbersbers May 20, 2021

Typos: "exlicitly", "a error" -> "an error"

* See [the testcase](https://github.com/keisen/tf-keras-vis/blob/47561f827b0ea89e0faab356ca3a9621b8662381/tests/tf-keras-vis/activation_maximization/activation_maximization_test.py#L188-L197) for details.


## Use Cases
Expand Down
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
"License :: OSI Approved :: MIT License",
"Operating System :: OS Independent",
],
python_requires='>=3.6, <3.9',
install_requires=['scipy==1.4.*', 'pillow==7.1.*', 'deprecated', 'imageio', 'packaging'],
python_requires='>=3.6, <3.10',
install_requires=['scipy', 'pillow', 'deprecated', 'imageio', 'packaging'],
extras_require={
'develop': ['flake8', 'isort', 'yapf', 'pytest<6.0', 'pytest-pep8', 'pytest-cov'],
'examples': ['jupyterlab==2.*', 'jedi==0.17.*', 'matplotlib'],
Expand Down

0 comments on commit 25d0b3b

Please sign in to comment.