Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

軽微なリファクタリング（20221126） #34

Closed
3 tasks done
keitakn opened this issue Nov 26, 2022 · 0 comments
Closed
3 tasks done

軽微なリファクタリング（20221126） #34

keitakn opened this issue Nov 26, 2022 · 0 comments
Assignees
@keitakn

Comments

@keitakn
Copy link
Owner

keitakn commented Nov 26, 2022 •
edited
Loading

Doneの定義

  • LgtmImagesのidがnumber型で返ってくるように変更されている事
  • export default の利用箇所が named exportに変更されている事
  • npm Packageが最新に更新されている事
@keitakn keitakn self-assigned this Nov 26, 2022
keitakn added a commit that referenced this issue Nov 26, 2022
@keitakn
🚧 #34
2461f04
@keitakn keitakn mentioned this issue Nov 26, 2022
Merged
3 tasks
keitakn added a commit that referenced this issue Nov 26, 2022
@keitakn
⬆️ #34 npm Packageを最新安定版に更新
e976dab
keitakn added a commit that referenced this issue Nov 26, 2022
@keitakn
♻️ #34 他でも利用するのでFetchLgtmImagesのResponseBody関連の関数を分離
c773f94
keitakn added a commit that referenced this issue Nov 26, 2022
@keitakn
🎨 #34 LgtmImagesのResponseをlgtm-cat-uiに合わせて変更
2b81ff7
keitakn added a commit that referenced this issue Nov 26, 2022
@keitakn
💚 #34 実際のAPIの返り値はidが文字列型なのでMockを修正
664eda1
keitakn added a commit that referenced this issue Nov 26, 2022
@keitakn
🎨 #34 JSONとして不自然な値なので自然な形に変更
c805c0e
keitakn added a commit that referenced this issue Nov 26, 2022
@keitakn
♻️ #34 ValidationProblemDetailsを指定するように変更
6a7840a
keitakn added a commit that referenced this issue Nov 26, 2022
@keitakn
♻️ #34 export default の利用箇所を named exportに変更
526ccea
@keitakn keitakn closed this as completed Nov 26, 2022
@keitakn keitakn mentioned this issue Nov 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keitakn keitakn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@keitakn