Allow administrators to resend professor emails

app/controllers/applicants_controller.rb

@@ -43,13 +43,7 @@ def create
 
     if @applicant.save
       begin
-        ApplicantMailer.account_email(@applicant).deliver
-        @applicant.positions.each do |position|
-          next if position.professor_emailed
-          professor = position.professor
-          ProfessorMailer.pending_recommendation(professor).deliver
-          position.professor_emailed = true
-        end
+        @applicant.send_emails
       rescue Errno::ECONNREFUSED
         redirect_to @applicant,
           notice: 'Your application was saved but the emails failed to send. Save this URL and contact the ASC for assistance'

app/controllers/professors_controller.rb

@@ -1,6 +1,6 @@
 class ProfessorsController < ApplicationController
-  before_action :signed_in_admin, only: [:index, :destroy]
-  before_action :set_professor, only: [:show, :edit, :update, :destroy]
+  before_action :signed_in_admin, only: [:index, :destroy, :email]
+  before_action :set_professor, only: [:show, :edit, :update, :destroy, :email]
 
   # GET /professors
   def index
@@ -31,6 +31,18 @@ def destroy
     redirect_to professors_url, notice: 'Professor was successfully destroyed.'
   end
 
+  # POST /professors/1/email
+  def email
+    begin
+      ProfessorMailer.pending_recommendation(@professor).deliver
+    rescue Errno::ECONNREFUSED
+      redirect_to professors_url,
+        notice: "The email failed to send. You can manually send the professor their URL: #{ professor_url(@professor) }"
+    else
+      redirect_to professors_url, notice: 'The email was sent successfully'
+    end
+  end
+
   private
     # Use callbacks to share common setup or constraints between actions.
     def set_professor

app/views/professors/index.html.erb

@@ -1,3 +1,5 @@
+<p id="notice"><%= notice %></p>
+
 <h1>All professors</h1>
 
 <table>
@@ -9,6 +11,7 @@
       <th></th>
       <th></th>
       <th></th>
+      <th></th>
     </tr>
   </thead>
 
@@ -21,6 +24,7 @@
         <td><%= link_to 'Show', professor %></td>
         <td><%= link_to 'Edit', edit_professor_path(professor) %></td>
         <td><%= link_to 'Delete', professor, method: :delete, data: { confirm: 'Are you sure?' } %></td>
+        <td><%= link_to 'Email', email_professor_path(professor), method: :post %></td>
       </tr>
     <% end %>
   </tbody>

config/routes.rb

@@ -2,7 +2,9 @@
   root 'applicants#new'
   resources :emails, except: [:new, :create, :destroy]
   resources :positions, except: [:new]
-  resources :professors, except: [:create, :new]
+  resources :professors, except: [:create, :new] do
+    post :email, on: :member
+  end
 
   resources :users, except: [:show]
 

spec/routing/professors_routing_spec.rb

@@ -7,19 +7,23 @@
     end
 
     it 'routes to #show' do
-      get('/professors/1').should route_to('professors#show', :id => '1')
+      get('/professors/1').should route_to('professors#show', id: '1')
     end
 
     it 'routes to #edit' do
-      get('/professors/1/edit').should route_to('professors#edit', :id => '1')
+      get('/professors/1/edit').should route_to('professors#edit', id: '1')
     end
 
     it 'routes to #update' do
-      put('/professors/1').should route_to('professors#update', :id => '1')
+      put('/professors/1').should route_to('professors#update', id: '1')
     end
 
     it 'routes to #destroy' do
-      delete('/professors/1').should route_to('professors#destroy', :id => '1')
+      delete('/professors/1').should route_to('professors#destroy', id: '1')
+    end
+
+    it 'routes to #email' do
+      post('/professors/1/email').should route_to('professors#email', id: '1')
     end
   end
 end

spec/views/professors/index.html.erb_spec.rb

@@ -5,21 +5,22 @@
     assign(:professors, [
       stub_model(Professor,
         name: 'Name',
-        email: 'Email',
+        email: 'addr',
         identifier: 'abc'
       ),
       stub_model(Professor,
         name: 'Name',
-        email: 'Email',
+        email: 'addr',
         identifier: 'abc'
       )
     ])
   end
 
   it 'renders a list of professors' do
     render
-    # Run the generator again with the --webrat flag if you want to use webrat matchers
+
     assert_select 'tr>td', text: 'Name'.to_s, count: 2
-    assert_select 'tr>td', text: "Email#{ EMAIL_SUFFIX }".to_s, count: 2
+    assert_select 'tr>td', text: "addr#{ EMAIL_SUFFIX }".to_s, count: 2
+    rendered.should match(/Email/)
   end
 end