Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing through arguments from bazel run #48

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Allow passing through arguments from bazel run #48

merged 1 commit into from
Mar 21, 2024

Conversation

hunshcn
Copy link
Contributor

@hunshcn hunshcn commented Mar 21, 2024

resolve #44

@hunshcn hunshcn mentioned this pull request Mar 21, 2024
Closed
alexeagle
alexeagle approved these changes Mar 21, 2024
View reviewed changes
Copy link

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this probably needs a documentation change as well? And be clear that the args provided to the rule come before those provided on the command line when invoking the multirunner

@keith keith mentioned this pull request Mar 21, 2024
Closed
@keith keith merged commit 9cc74d3 into keith:main Mar 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow user to pass arguments via bazel run
3 participants
@hunshcn @alexeagle @keith