Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #14

Closed
10 tasks done
keithamoss opened this issue Sep 14, 2018 · 0 comments
Closed
10 tasks done

Refactoring #14

keithamoss opened this issue Sep 14, 2018 · 0 comments

Comments

@keithamoss
Copy link
Owner

keithamoss commented Sep 14, 2018 •
edited
Loading

  • Break app.tsx up into its respective modules (re-ducks and redux-typed-modules and Strongly typed Redux modules made easy!)
  • Cleanup @ts-ignore junk in app.tsx
  • Use selectors
  • Types for all ducks
  • Types for all components
  • Assignments should be indexed by assignment_id for easier updating in future
  • We shouldn't be modifying tweets with reviewer_id and review_status
  • Don't use getState()
  • Use Serializers on the backend
  • Add Python linting
@keithamoss keithamoss changed the title Cleanup @ts-ignore junk in app.tsx Refactoring Sep 15, 2018
keithamoss added a commit that referenced this issue Dec 13, 2018
@keithamoss
Refactoring for #14
dbc654f
keithamoss added a commit that referenced this issue Dec 13, 2018
@keithamoss
Now with selectors #14
a1fc584
keithamoss added a commit that referenced this issue Dec 13, 2018
@keithamoss
Now components have types #14
83bb9d2
keithamoss added a commit that referenced this issue Dec 13, 2018
@keithamoss
More refactoring - assignments are now indexed by their ids #14
1312fd1
keithamoss added a commit that referenced this issue Dec 13, 2018
@keithamoss
No more direct use of getState() #14
93d4e80
keithamoss added a commit that referenced this issue Dec 13, 2018
@keithamoss
Oops, wrong types #14
0b5938f
keithamoss added a commit that referenced this issue Dec 13, 2018
@keithamoss
Don't modify tweet objects client-side - store tweet -> assignment ma…
b536c1c 
…pping elsewhere #14
keithamoss added a commit that referenced this issue Dec 13, 2018
@keithamoss
Now with Django Rest Framework Serializers #14
81fc27d
keithamoss added a commit that referenced this issue Dec 13, 2018
@keithamoss
Now with flake8 and autopep8 linting #14
7d78121
keithamoss added a commit that referenced this issue Dec 13, 2018
@keithamoss
Removing unused imports #14
611d163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@keithamoss