Add noopener along with _target blank for security #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for your contribution. I just had to jump in to thank you. I'm working on something atm and will review this PR during the coming weekend :) This was in the pipeline for v1.1 as per #GH-3 so please also allow some time for other new features to be completed which may be released at once. Again, thank you for your contribution. I promise you to look into the PR in the next few days! You're a ⭐️ |
|
Cool! |
buren
changed the title
This is for security reasons. Without it if a user clicks an external link the target page will have full access to the `window` object! To fix this we add `rel="noopener noreferrer"` along with `_target="blank"`. `noreferrer` is for older browsers that does not support `noopener`. For more information see https://mathiasbynens.github.io/rel-noopener/
|
@buren Thank you for this PR. It all great :) Can you please edit the PR and ask to merge it to this branch: pre-release-v1.1 . I will merge into master after a couple of additions from separate issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for security reasons. Without it, if a user clicks an external link the target page will have full access to the
windowobject!To fix this we add
rel="noopener noreferrer"along with_target="blank".noreferreris for older browsers that does not supportnoopener.For more information see https://mathiasbynens.github.io/rel-noopener/