Feature/update deps remove node 6 support #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: Add import syntax to README
# Conflicts: # CHANGELOG.md # package.json
|
@niftylettuce Would love your thoughts on this PR. |
|
I don't think we should drop support for Node 6 to be honest. There is not a valid reason why we should suddenly drop the support. |
|
Like other packages out there, we should be as far back compatible as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to update all package dependencies as there were potential security issues in some of the required packages. Some of these updated dependencies no longer support Node < 8 and as such, the library has been set to have the node engine requirement at Node >= 8. Travis test script has removed Node 6 and added Node 12.
This seems acceptable to me as Node < 8 is no longer supported and Node 8 will only be supported through 2019-12.31.
Although there is no change in functionality, I have bumped the version to 3.0.0 in case anyone is using the 2.x.x version in Node 6/7 it will not cause the library to fail as long as their
package.jsonfile indicates the"^2.7.0"syntax to lock their version at the 2.x.x release.