Missing values should default to empty strings for errorOnRegex #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO the
RegExp().test()
forerrorOnRegex
should default missing - or actually any non-string - values to""
.Currently,
^(true|undefined)$
is required to require a variable to either be"true"
or not set. This feels hacky as it relies onRegExp().test()
casting non-string values to a string, in which caseundefined
becomes"undefined"
.As environment variables should always be strings, I think it's better to default non-strings to
""
so that you can use^(true)?$
to require a value to either be"true"
or not set.Without the change in
src/index.js
the newly added test fails with:Also see #41