Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When disableUntil date is higher than the ngModel date, the date will not show #34

Closed
STheFox opened this issue Mar 31, 2020 · 2 comments

Comments

@STheFox
Copy link

STheFox commented Mar 31, 2020

Hi,

When a date is initialized by using ngModel to let's say 14/05/2019, and the disableUntil is set to 01/01/2020, the date will not be shown. In the previous version of the datepicker (mydatepicker), the date would still be shown.

I created a stackblitz where you can simulate the issue. https://stackblitz.com/edit/angular-9-1-0-angular-mydatepicker

The previous approach seemed to me to be better in user experience. As it is now, it doesn't seem like a value was initialized.

Thanks.

@STheFox STheFox changed the title When disableUntil is set after the ngModel, the date will not show When disableUntil date is higher than the ngModel date, the date will not show Mar 31, 2020
kekeh added a commit that referenced this issue Apr 1, 2020
@kekeh
Copy link
Owner

kekeh commented Apr 1, 2020

Hi @STheFox

I fixed this issue. Install new version 0.5.4.

@kekeh kekeh closed this as completed Apr 1, 2020
@STheFox
Copy link
Author

STheFox commented Apr 1, 2020

@kekeh Thanks! I can confirm this issue is fixed on the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants