Improved detection for mostly larger version tag.

kekyo · Oct 27, 2023 · 0365801 · 0365801
1 parent f1e0d0f
commit 0365801
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/RelaxVersioner.Core/Analyzer.cs b/RelaxVersioner.Core/Analyzer.cs
@@ -10,6 +10,7 @@
 #nullable enable
 
 using System.Collections.Generic;
+using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
 
@@ -89,19 +90,16 @@ internal static class Analyzer
                 break;
             }
 
-            var found = false;
-            foreach (var tag in commit.Tags)
-            {
-                if (Version.TryParse(tag.Name, out var v2))
-                {
-                    version = v2;
-                    reached.Add(commit, version);
-                    found = true;
-                    break;
-                }
-            }
-            if (found)
+            // Detected mostly larger version tag.
+            var candidates = commit.Tags.
+                Select(tag => Version.TryParse(tag.Name, out var v) ? v : null!).
+                Where(v => v != null).
+                OrderByDescending(v => v).
+                ToArray();
+            if (candidates.Length >= 1)
             {
+                version = candidates[0];
+                reached.Add(commit, version);
                 break;
             }