Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to correctly scan Trailblazer will crash the character scanner #49

Closed
kel-z opened this issue Jan 8, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@kel-z
Copy link
Owner

kel-z commented Jan 8, 2024

I can't reproduce it myself (probably some combination of graphic settings and game resolution), but it is possible for the scanner to not recognize the Trailblazer character and try to read the character name instead (which will most likely produce a KeyError and crash the parser since Trailblazer's name is the account name).

Either fine-tune the Trailblazer recognition logic, or wrap everything in a try-catch to skip a character if it fails to parse. Whichever comes first.

@kel-z kel-z added the bug Something isn't working label Jan 8, 2024
@kel-z
Copy link
Owner Author

kel-z commented Feb 9, 2024

If HSR is running slowly, when clicking between different characters, the character name might not update fast enough before the scanner screenshots the name, resulting in duplicate character entries.

One solution is to keep a record of all seen characters so far, then if a duplicate is detected, wait and retry the name parse again, with a max of 5 attempts.

@kel-z
Copy link
Owner Author

kel-z commented Feb 9, 2024

This might explain why Trailblazer's name sometimes gets parsed, because after clicking off of Trailblazer and onto the next character, Trailblazer's name will get screenshotted and fail the Trailblazer check, thus causing the scanner to think the parsed name is an in-game character name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant