fix(deps): update dependency luxon to v3.3.0 & add @types/luxon #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intcreator
approved these changes
Aug 26, 2023
ncb000gt
pushed a commit
that referenced
this pull request
Aug 26, 2023
## [2.4.2](v2.4.1...v2.4.2) (2023-08-26) ### 🐛 Bug Fixes * **deps:** update dependency luxon to v3.3.0 & add [@types](https://github.com/types)/luxon ([#689](#689)) ([c95a449](c95a449)), closes [#688](#688)
|
🎉 This PR is included in version 2.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
34 tasks
sheerlox
added a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 10, 2023
…ktiv#689) ## Description - added `@types/luxon` to dependencies - updated Luxon from `v3.2.1` to `v3.3.0` (avoided `v3.4.0` since types aren't available for that version yet). ## Related Issue Fixes kelektiv#688. ## Motivation and Context This library needs to depend on `@types/luxon` since we now export our own types. See the related issue for the error this fixes. ## How Has This Been Tested? - checked that TypeScript now correctly loads the Luxon types - ran tests locally ## Types of changes - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: - [X] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [X] All new and existing tests passed. - [ ] If my change introduces a breaking change, I have added a `!` after the type/scope in the title (see the Conventional Commits standard).
ncb000gt
pushed a commit
that referenced
this pull request
Sep 10, 2023
## [3.0.0-beta.4](v3.0.0-beta.3...v3.0.0-beta.4) (2023-09-10) ### 🐛 Bug Fixes * **deps:** update dependency luxon to v3.3.0 & add [@types](https://github.com/types)/luxon ([#689](#689)) ([c95a449](c95a449)), closes [#688](#688) * fix range parsing when upper limit = 0 ([#687](#687)) ([d96746f](d96746f)) ### 🚨 Tests * add TS types check ([#690](#690)) ([f046016](f046016))
|
🎉 This PR is included in version 3.0.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
patrickm68
added a commit
to patrickm68/node-cron-types
that referenced
this pull request
Sep 14, 2023
## [2.4.2](kelektiv/node-cron@v2.4.1...v2.4.2) (2023-08-26) ### 🐛 Bug Fixes * **deps:** update dependency luxon to v3.3.0 & add [@types](https://github.com/types)/luxon ([#689](kelektiv/node-cron#689)) ([c95a449](kelektiv/node-cron@c95a449)), closes [#688](kelektiv/node-cron#688)
sheerlox
added a commit
that referenced
this pull request
Sep 27, 2023
## Description - added `@types/luxon` to dependencies - updated Luxon from `v3.2.1` to `v3.3.0` (avoided `v3.4.0` since types aren't available for that version yet). ## Related Issue Fixes #688. ## Motivation and Context This library needs to depend on `@types/luxon` since we now export our own types. See the related issue for the error this fixes. ## How Has This Been Tested? - checked that TypeScript now correctly loads the Luxon types - ran tests locally ## Types of changes - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: - [X] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [X] All new and existing tests passed. - [ ] If my change introduces a breaking change, I have added a `!` after the type/scope in the title (see the Conventional Commits standard).
sheerlox
pushed a commit
that referenced
this pull request
Sep 27, 2023
## [2.4.2](v2.4.1...v2.4.2) (2023-08-26) ### 🐛 Bug Fixes * **deps:** update dependency luxon to v3.3.0 & add [@types](https://github.com/types)/luxon ([#689](#689)) ([c95a449](c95a449)), closes [#688](#688)
sheerlox
added a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 27, 2023
…ktiv#689) ## Description - added `@types/luxon` to dependencies - updated Luxon from `v3.2.1` to `v3.3.0` (avoided `v3.4.0` since types aren't available for that version yet). ## Related Issue Fixes kelektiv#688. ## Motivation and Context This library needs to depend on `@types/luxon` since we now export our own types. See the related issue for the error this fixes. ## How Has This Been Tested? - checked that TypeScript now correctly loads the Luxon types - ran tests locally ## Types of changes - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: - [X] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [X] All new and existing tests passed. - [ ] If my change introduces a breaking change, I have added a `!` after the type/scope in the title (see the Conventional Commits standard).
sheerlox
pushed a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 27, 2023
## [2.4.2](kelektiv/node-cron@v2.4.1...v2.4.2) (2023-08-26) ### 🐛 Bug Fixes * **deps:** update dependency luxon to v3.3.0 & add [@types](https://github.com/types)/luxon ([kelektiv#689](kelektiv#689)) ([c95a449](kelektiv@c95a449)), closes [kelektiv#688](kelektiv#688)
sheerlox
added a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 29, 2023
…ktiv#689) ## Description - added `@types/luxon` to dependencies - updated Luxon from `v3.2.1` to `v3.3.0` (avoided `v3.4.0` since types aren't available for that version yet). ## Related Issue Fixes kelektiv#688. ## Motivation and Context This library needs to depend on `@types/luxon` since we now export our own types. See the related issue for the error this fixes. ## How Has This Been Tested? - checked that TypeScript now correctly loads the Luxon types - ran tests locally ## Types of changes - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: - [X] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [X] All new and existing tests passed. - [ ] If my change introduces a breaking change, I have added a `!` after the type/scope in the title (see the Conventional Commits standard).
sheerlox
pushed a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 29, 2023
## [2.4.2](kelektiv/node-cron@v2.4.1...v2.4.2) (2023-08-26) ### 🐛 Bug Fixes * **deps:** update dependency luxon to v3.3.0 & add [@types](https://github.com/types)/luxon ([kelektiv#689](kelektiv#689)) ([c95a449](kelektiv@c95a449)), closes [kelektiv#688](kelektiv#688)
sheerlox
added a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 29, 2023
…ktiv#689) ## Description - added `@types/luxon` to dependencies - updated Luxon from `v3.2.1` to `v3.3.0` (avoided `v3.4.0` since types aren't available for that version yet). ## Related Issue Fixes kelektiv#688. ## Motivation and Context This library needs to depend on `@types/luxon` since we now export our own types. See the related issue for the error this fixes. ## How Has This Been Tested? - checked that TypeScript now correctly loads the Luxon types - ran tests locally ## Types of changes - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: - [X] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [X] All new and existing tests passed. - [ ] If my change introduces a breaking change, I have added a `!` after the type/scope in the title (see the Conventional Commits standard).
sheerlox
added
type:build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@types/luxonto dependenciesv3.2.1tov3.3.0(avoidedv3.4.0since types aren't available for that version yet).Related Issue
Fixes #688.
Motivation and Context
This library needs to depend on
@types/luxonsince we now export our own types. See the related issue for the error this fixes.How Has This Been Tested?
Types of changes
Checklist:
!after the type/scope in the title (see the Conventional Commits standard).