fix: revert runOnce breaking changes #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a61d8c9.
…elektiv#740)" This reverts commit ee54dd5.
sheerlox
force-pushed
the
fix/full-revert-runOnce
branch
from
8ea5fdd
to
3f1e2a1
Compare
intcreator
approved these changes
Oct 29, 2023
ncb000gt
pushed a commit
that referenced
this pull request
Oct 29, 2023
## [3.1.6](v3.1.5...v3.1.6) (2023-10-29) ### 🐛 Bug Fixes * revert runOnce breaking changes ([#760](#760)) ([7cb53ec](7cb53ec)) ### ⚙️ Continuous Integrations * **action:** update actions/checkout action to v4 ([#755](#755)) ([d0d70c6](d0d70c6)) * **action:** update github/codeql-action action to v2.22.4 ([#752](#752)) ([04454c3](04454c3)) * **action:** update github/codeql-action action to v2.22.5 ([#758](#758)) ([2dff183](2dff183)) * **action:** update ossf/scorecard-action action to v2.3.1 ([#754](#754)) ([41d21f1](41d21f1)) ### ♻️ Chores * **deps:** update dependency [@commitlint](https://github.com/commitlint)/cli to v18.2.0 ([#759](#759)) ([4cb466e](4cb466e)) * **deps:** update dependency [@types](https://github.com/types)/node to v20.8.8 ([#756](#756)) ([361728e](361728e)) * **deps:** update dependency [@types](https://github.com/types)/node to v20.8.9 ([#757](#757)) ([e2b1bac](e2b1bac)) * **deps:** update dependency [@typescript-eslint](https://github.com/typescript-eslint)/eslint-plugin to v6.9.0 ([#753](#753)) ([9cec04f](9cec04f))
|
🎉 This PR is included in version 3.1.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation & Context
This PR restores the original
runOnceproperty, which was changed in #740 without considering it a breaking change since it was an undocumented internal property. That was a mistake because consumers relied on it.The property was added back as a read-only getter in #751, which was another naive decision from me, because not only did consumers rely on reading it, but it seems (based on the Renovate passing tests percentage below) that they actually also mutate the property to change their jobs' behavior.
Related Issues
How Has This Been Tested?
Test case already present from #740.
Types of changes
Checklist:
!after the type/scope in the title (see the Conventional Commits standard).