-
-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid 14 bit integer overflow in clockseq #26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broofa
added a commit
that referenced
this pull request
Dec 30, 2011
Avoid 14 bit integer overflow in clockseq
Good catch, btw. Sorry I didn't merge this before now - 'Been really busy with work and holiday stuff. |
qgerome
pushed a commit
to qgerome/uuid
that referenced
this pull request
May 27, 2020
Update mocha to the latest version 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just got the quite unlikely case of a clockseq overlow:
The clock-seq-part is
c000
which is invalid. Apparently we got an overflow from0x3fff
to0x4000
of the clockseq here.I tried to write a test to catch this, but it's currently not possible since we cannot control the _seedBytes from the outside. Still I think my patch should fix this.
Sorry, that there's some other old stuff in the commit range, I don't really get it how to keep that out of here....