New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax contextlib2 requirement #222
Conversation
0.5.5 is not the latest version any more.
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
=======================================
Coverage 98.87% 98.87%
=======================================
Files 1 1
Lines 443 443
=======================================
Hits 438 438
Misses 5 5 Continue to review full report at Codecov.
|
Is there any problem that is solved with this upgrade? |
This is purely for depending projects that also need a newer version of contextlib2 directly or indirectly through another library. |
Ah, that's fair. Have you tested that schema works with the latest version of contextlib2? |
I just did and it does work. I did not add an upper bound because contextlib2 is a compatibility layer that should not change existing functionality unless python proper does the same, in which case your code has to adapt anyway. |
This depends on contextlib2 and mock. The preConfigure hook can probably be removed with the next version bump, see keleshev/schema#222.
Alright, sounds reasonable, thanks! |
This depends on contextlib2 and mock. The preConfigure hook can probably be removed with the next version bump, see keleshev/schema#222.
This depends on contextlib2 and mock. The preConfigure hook can probably be removed with the next version bump, see keleshev/schema#222. (cherry picked from commit aa1ad7b)
@skorokithakis can you release this change on pypi please? |
@skorokithakis it would make sense as |
Certainly, I'll do that soon. |
Released 0.7.2. |
0.5.5 is not the latest version any more.