Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax contextlib2 requirement #222

Merged
merged 1 commit into from Nov 3, 2019
Merged

Relax contextlib2 requirement #222

merged 1 commit into from Nov 3, 2019

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Nov 2, 2019

0.5.5 is not the latest version any more.

0.5.5 is not the latest version any more.
@codecov-io
Copy link

Codecov Report

Merging #222 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files           1        1           
  Lines         443      443           
=======================================
  Hits          438      438           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777a9a9...aceeaf9. Read the comment docs.

@skorokithakis
Copy link
Collaborator

Is there any problem that is solved with this upgrade?

@tobim
Copy link
Contributor Author

tobim commented Nov 2, 2019

This is purely for depending projects that also need a newer version of contextlib2 directly or indirectly through another library.

@skorokithakis
Copy link
Collaborator

Ah, that's fair. Have you tested that schema works with the latest version of contextlib2?

@tobim
Copy link
Contributor Author

tobim commented Nov 3, 2019

I just did and it does work. I did not add an upper bound because contextlib2 is a compatibility layer that should not change existing functionality unless python proper does the same, in which case your code has to adapt anyway.

@tobim tobim mentioned this pull request Nov 3, 2019
10 tasks
tobim added a commit to tobim/nixpkgs that referenced this pull request Nov 3, 2019
This depends on contextlib2 and mock. The preConfigure hook
can probably be removed with the next version bump, see
keleshev/schema#222.
@skorokithakis
Copy link
Collaborator

Alright, sounds reasonable, thanks!

@skorokithakis skorokithakis merged commit 0e7e684 into keleshev:master Nov 3, 2019
jonringer pushed a commit to NixOS/nixpkgs that referenced this pull request Nov 5, 2019
This depends on contextlib2 and mock. The preConfigure hook
can probably be removed with the next version bump, see
keleshev/schema#222.
@tobim tobim deleted the patch-1 branch November 5, 2019 15:20
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 5, 2019
This depends on contextlib2 and mock. The preConfigure hook
can probably be removed with the next version bump, see
keleshev/schema#222.

(cherry picked from commit aa1ad7b)
@graingert
Copy link

@skorokithakis can you release this change on pypi please?

@graingert
Copy link

@skorokithakis it would make sense as 0.7.1.patch0

@skorokithakis
Copy link
Collaborator

Certainly, I'll do that soon.

@skorokithakis
Copy link
Collaborator

Released 0.7.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants