Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can potentially break oh-my-posh and starship #189

Open
brian6932 opened this issue Sep 8, 2022 · 7 comments
Open

Can potentially break oh-my-posh and starship #189

brian6932 opened this issue Sep 8, 2022 · 7 comments

Comments

@brian6932
Copy link

Original thread: JanDeDobbeleer/oh-my-posh#2758
I am not aware of who/what the responsible party is in this, however, since the dev of oh-my-posh wasn't sure who/what was responsible either, I opened this mirror issue

@mattcargile
Copy link
Contributor

I've had this happen before seemingly randomly. It may be related to when I zoom in and out in Windows Terminal. I usually have to clear/cls the screen or use CTRL + l to "clear" the screen. I think we'll need a better repro to really get to the bottom of it.

@sim590
Copy link

sim590 commented Aug 7, 2023

Also see my bug report on oh-my-posh:

JanDeDobbeleer/oh-my-posh#4122

It seems like it is the same. It's easy to reproduce the way I do it, I feel.

@riotrah
Copy link

riotrah commented Feb 19, 2024

Just bumping this - this is quite a weird bug. sim590's bug report is more thorough and reaffirms that this is likely due to PSFzf's implementation and not something about oh-my-posh specifically.

@kelleyma49
Copy link
Owner

I can't recreate this issue. See the attached video. Do you have a language set other than English?

My environment:

PowerShell 7.4
fzf 0.46.1
Oh My Posh 19.11.3
CaskaydiaCove Nerd Font

oh-my-posh

@brian6932
Copy link
Author

brian6932 commented Apr 22, 2024

No, I use
Shell: PowerShell 7.5.0-preview.2
Terminal: alacritty 0.14.0-dev
oh-my-posh: 19.24.2
fzf: 0.50.0 (f97d275)
PSFzf: c604e1b
Theme: Pure

I ever so slightly modify the Pure theme (I disable the transient_prompt). Repeatedly pressing CTRL+R or TAB can often repro this bug (and make sure you have long shell history, larger than your window size).

@sim590
Copy link

sim590 commented Apr 22, 2024

@kelleyma49 In your video you seem to mostly be using ENTER or any other key input that would end up selecting the line your cursor was on. However, my report stated that I interrupt the program in order to get the issue, so you would need to interrupt FZF with CTRL+c. Do it repeatedly and you should trigger the issue quickly...

@brian6932
Copy link
Author

Yes, I typically used ESC

@brian6932 brian6932 changed the title Can potentially break oh-my-posh Can potentially break oh-my-posh and starship Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants