Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird breakage caused from activating fzf on v9.0.0 #2758

Closed
1 task done
brian6932 opened this issue Sep 7, 2022 · 12 comments
Closed
1 task done

Weird breakage caused from activating fzf on v9.0.0 #2758

brian6932 opened this issue Sep 7, 2022 · 12 comments
Assignees
@JanDeDobbeleer
Labels
🐛 bug Something isn't working 🤔 info needed Further information is requested

Comments

@brian6932
Copy link
Contributor

brian6932 commented Sep 7, 2022 •
edited
Loading

Code of Conduct

  • I agree to follow this project's Code of Conduct

What happened?

I activated fzf, and it broke my theme (hard to reproduce)
image

Theme:

Pure

Term:

alacritty 0.10.1 (2844606)

OS:

Windows 10

Shell:

PowerShell 7.3.0-preview.7

Log output: 
�[1mVersion:�[0m 9.0.0

�[1mSegments:�[0m

ConsoleTitle(true)   -   0 ms - (Admin) ~
session(true)        -   0 ms - �[38;2;191;97;106mBrian �[0m
path(true)           -   0 ms - �[38;2;129;161;193m~ �[0m
git(false)           -  29 ms - 
executiontime(false) -   0 ms - 
exit(true)           -   1 ms - �[38;2;180;142;173m❯ �[0m

�[1mRun duration:�[0m 52.3081ms

�[1mCache path:�[0m ~\AppData\Local\oh-my-posh

�[1mConfig path:�[0m ~\pureCustom.omp.json

�[1mLogs:�[0m

2022/09/07 18:10:34 debug: Getenv
~\AppData\Local
2022/09/07 18:10:34 Getenv duration: 0s, args: LOCALAPPDATA
2022/09/07 18:10:34 CachePath duration: 0s, args: 
2022/09/07 18:10:34 debug: Getenv
~\pureCustom.omp.json
2022/09/07 18:10:34 Getenv duration: 0s, args: POSH_THEME
2022/09/07 18:10:34 Shell duration: 14.0873ms, args: 
2022/09/07 18:10:34 resolveConfigPath duration: 14.0873ms, args: 
2022/09/07 18:10:34 Init duration: 18.1087ms, args: 
2022/09/07 18:10:34 Flags duration: 0s, args: 
2022/09/07 18:10:34 config.loadConfig duration: 2.0117ms, args: 
2022/09/07 18:10:34 Flags duration: 0s, args: 
2022/09/07 18:10:34 debug: Getenv

2022/09/07 18:10:34 Getenv duration: 0s, args: OMP_CACHE_DISABLED
2022/09/07 18:10:34 WindowsRegistryKeyValue duration: 0s, args: HKEY_CURRENT_USER\Software\Microsoft\Windows\DWM\ColorizationColor
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 debug: WindowsRegistryKeyValue
ColorizationColor(DWORD): 0xC4363C48
2022/09/07 18:10:34 Root duration: 502.9µs, args: 
2022/09/07 18:10:34 Shell duration: 0s, args: 
2022/09/07 18:10:34 ErrorCode duration: 0s, args: 
2022/09/07 18:10:34 IsWsl duration: 0s, args: 
2022/09/07 18:10:34 debug: Pwd
~
2022/09/07 18:10:34 Pwd duration: 0s, args: 
2022/09/07 18:10:34 debug: Home
~
2022/09/07 18:10:34 debug: Home
~
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 debug: User
Brian
2022/09/07 18:10:34 User duration: 0s, args: 
2022/09/07 18:10:34 debug: Host
Beast-Master-64
2022/09/07 18:10:34 Host duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 TemplateCache duration: 502.9µs, args: 
2022/09/07 18:10:34 Flags duration: 0s, args: 
2022/09/07 18:10:34 debug: Pwd
~
2022/09/07 18:10:34 Pwd duration: 0s, args: 
2022/09/07 18:10:34 debug: Home
~
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 debug: Getenv

2022/09/07 18:10:34 Getenv duration: 0s, args: SSH_CONNECTION
2022/09/07 18:10:34 debug: Getenv

2022/09/07 18:10:34 Getenv duration: 0s, args: SSH_CLIENT
2022/09/07 18:10:34 TemplateCache duration: 0s, args: 
2022/09/07 18:10:34 TemplateCache duration: 0s, args: 
2022/09/07 18:10:34 Shell duration: 0s, args: 
2022/09/07 18:10:34 debug: Pwd
~
2022/09/07 18:10:34 Pwd duration: 0s, args: 
2022/09/07 18:10:34 debug: Home
~
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 debug: Pwd
~
2022/09/07 18:10:34 Pwd duration: 0s, args: 
2022/09/07 18:10:34 Flags duration: 0s, args: 
2022/09/07 18:10:34 debug: Pwd
~
2022/09/07 18:10:34 Pwd duration: 0s, args: 
2022/09/07 18:10:34 debug: Home
~
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 PathSeparator duration: 0s, args: 
2022/09/07 18:10:34 PathSeparator duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 IsWsl duration: 0s, args: 
2022/09/07 18:10:34 StackCount duration: 0s, args: 
2022/09/07 18:10:34 DirIsWritable duration: 0s, args: 
2022/09/07 18:10:34 TemplateCache duration: 0s, args: 
2022/09/07 18:10:34 TemplateCache duration: 0s, args: 
2022/09/07 18:10:34 Shell duration: 0s, args: 
2022/09/07 18:10:34 Flags duration: 0s, args: 
2022/09/07 18:10:34 debug: Pwd
~
2022/09/07 18:10:34 Pwd duration: 0s, args: 
2022/09/07 18:10:34 debug: Home
~
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 debug: CommandPath
~\scoop\shims\git.exe
2022/09/07 18:10:34 CommandPath duration: 29.1705ms, args: git.exe
2022/09/07 18:10:34 HasCommand duration: 29.1705ms, args: git.exe
2022/09/07 18:10:34 debug: Pwd
~
2022/09/07 18:10:34 Pwd duration: 0s, args: 
2022/09/07 18:10:34 error: HasParentFilePath
CreateFile C:\.git: The system cannot find the file specified.
2022/09/07 18:10:34 HasParentFilePath duration: 503.1µs, args: .git
2022/09/07 18:10:34 Flags duration: 0s, args: 
2022/09/07 18:10:34 debug: Pwd
~
2022/09/07 18:10:34 Pwd duration: 0s, args: 
2022/09/07 18:10:34 debug: Home
~
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 ExecutionTime duration: 0s, args: 
2022/09/07 18:10:34 Flags duration: 0s, args: 
2022/09/07 18:10:34 debug: Pwd
~
2022/09/07 18:10:34 Pwd duration: 0s, args: 
2022/09/07 18:10:34 debug: Home
~
2022/09/07 18:10:34 GOOS duration: 0s, args: 
2022/09/07 18:10:34 ErrorCode duration: 0s, args: 
2022/09/07 18:10:34 TemplateCache duration: 0s, args: 
2022/09/07 18:10:34 TemplateCache duration: 0s, args: 
2022/09/07 18:10:34 Shell duration: 0s, args: 
2022/09/07 18:10:34 TemplateCache duration: 0s, args: 
2022/09/07 18:10:34 debug: Getenv
~\AppData\Local
2022/09/07 18:10:34 Getenv duration: 0s, args: LOCALAPPDATA
2022/09/07 18:10:34 CachePath duration: 0s, args: 
2022/09/07 18:10:34 Flags duration: 0s, args:
@brian6932 brian6932 added the 🐛 bug Something isn't working label Sep 7, 2022
@JanDeDobbeleer
Copy link
Owner

@brian6932 this doesn't happen for me, what did you use to enable fzf? I know there's different options, and looking at the changes in 9, it can't be linked to that.

@JanDeDobbeleer JanDeDobbeleer added the 🤔 info needed Further information is requested label Sep 8, 2022
@lewis-yeung
Copy link
Contributor

@brian6932 I noticed that you use Alacritty Terminal. Could this be an Alacritty related issue?

@JanDeDobbeleer
Copy link
Owner

@lewis-yeung good catch. Alacrity isn't as good (yet). Lots of weird issues with ANSI.

@brian6932
Copy link
Contributor Author

brian6932 commented Sep 8, 2022 •
edited
Loading

Very possible 🤷
It seems like I can reproduce this by spamming tab and alternating with esc when my line is at the bottom of my term, but it's very tough

@brian6932
Copy link
Contributor Author

brian6932 commented Sep 8, 2022 •
edited
Loading

image
After more testing, I can confirm this is not an Alacritty issue, I was able to reproduce this on conhost @lewis-yeung

Debug logs: 
�[1mVersion:�[0m 9.0.0

�[1mSegments:�[0m

ConsoleTitle(true)   -   1 ms - (Admin) ~
session(true)        -   0 ms - �[38;2;191;97;106mBrian �[0m
path(true)           -   0 ms - �[38;2;129;161;193m~ �[0m
git(false)           -  29 ms - 
executiontime(false) -   0 ms - 
exit(true)           -   1 ms - �[38;2;180;142;173m❯ �[0m

�[1mRun duration:�[0m 51.8378ms

�[1mCache path:�[0m ~\AppData\Local\oh-my-posh

�[1mConfig path:�[0m ~\pureCustom.omp.json

�[1mLogs:�[0m

2022/09/08 09:08:01 debug: Getenv
~\AppData\Local
2022/09/08 09:08:01 Getenv duration: 0s, args: LOCALAPPDATA
2022/09/08 09:08:01 CachePath duration: 0s, args: 
2022/09/08 09:08:01 debug: Getenv
~\pureCustom.omp.json
2022/09/08 09:08:01 Getenv duration: 0s, args: POSH_THEME
2022/09/08 09:08:01 Shell duration: 12.0652ms, args: 
2022/09/08 09:08:01 resolveConfigPath duration: 12.0652ms, args: 
2022/09/08 09:08:01 Init duration: 19.1037ms, args: 
2022/09/08 09:08:01 Flags duration: 0s, args: 
2022/09/08 09:08:01 config.loadConfig duration: 502.9µs, args: 
2022/09/08 09:08:01 Flags duration: 0s, args: 
2022/09/08 09:08:01 debug: Getenv

2022/09/08 09:08:01 Getenv duration: 0s, args: OMP_CACHE_DISABLED
2022/09/08 09:08:01 WindowsRegistryKeyValue duration: 0s, args: HKEY_CURRENT_USER\Software\Microsoft\Windows\DWM\ColorizationColor
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 debug: WindowsRegistryKeyValue
ColorizationColor(DWORD): 0xC4363C48
2022/09/08 09:08:01 Root duration: 0s, args: 
2022/09/08 09:08:01 Shell duration: 0s, args: 
2022/09/08 09:08:01 ErrorCode duration: 0s, args: 
2022/09/08 09:08:01 IsWsl duration: 0s, args: 
2022/09/08 09:08:01 debug: Pwd
~
2022/09/08 09:08:01 Pwd duration: 503.7µs, args: 
2022/09/08 09:08:01 debug: Home
~
2022/09/08 09:08:01 debug: Home
~
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 debug: User
Brian
2022/09/08 09:08:01 User duration: 0s, args: 
2022/09/08 09:08:01 debug: Host
Beast-Master-64
2022/09/08 09:08:01 Host duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 TemplateCache duration: 503.7µs, args: 
2022/09/08 09:08:01 Flags duration: 0s, args: 
2022/09/08 09:08:01 debug: Pwd
~
2022/09/08 09:08:01 Pwd duration: 0s, args: 
2022/09/08 09:08:01 debug: Home
~
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 debug: Getenv

2022/09/08 09:08:01 Getenv duration: 0s, args: SSH_CONNECTION
2022/09/08 09:08:01 debug: Getenv

2022/09/08 09:08:01 Getenv duration: 0s, args: SSH_CLIENT
2022/09/08 09:08:01 TemplateCache duration: 0s, args: 
2022/09/08 09:08:01 TemplateCache duration: 0s, args: 
2022/09/08 09:08:01 Shell duration: 0s, args: 
2022/09/08 09:08:01 debug: Pwd
~
2022/09/08 09:08:01 Pwd duration: 0s, args: 
2022/09/08 09:08:01 debug: Home
~
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 debug: Pwd
~
2022/09/08 09:08:01 Pwd duration: 0s, args: 
2022/09/08 09:08:01 Flags duration: 0s, args: 
2022/09/08 09:08:01 debug: Pwd
~
2022/09/08 09:08:01 Pwd duration: 0s, args: 
2022/09/08 09:08:01 debug: Home
~
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 PathSeparator duration: 0s, args: 
2022/09/08 09:08:01 PathSeparator duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 IsWsl duration: 0s, args: 
2022/09/08 09:08:01 StackCount duration: 0s, args: 
2022/09/08 09:08:01 DirIsWritable duration: 0s, args: 
2022/09/08 09:08:01 TemplateCache duration: 0s, args: 
2022/09/08 09:08:01 TemplateCache duration: 0s, args: 
2022/09/08 09:08:01 Shell duration: 0s, args: 
2022/09/08 09:08:01 Flags duration: 0s, args: 
2022/09/08 09:08:01 debug: Pwd
~
2022/09/08 09:08:01 Pwd duration: 0s, args: 
2022/09/08 09:08:01 debug: Home
~
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:01 GOOS duration: 0s, args: 
2022/09/08 09:08:02 debug: CommandPath
~\scoop\shims\git.exe
2022/09/08 09:08:02 CommandPath duration: 29.7144ms, args: git.exe
2022/09/08 09:08:02 HasCommand duration: 29.7144ms, args: git.exe
2022/09/08 09:08:02 debug: Pwd
~
2022/09/08 09:08:02 Pwd duration: 0s, args: 
2022/09/08 09:08:02 error: HasParentFilePath
CreateFile C:\.git: The system cannot find the file specified.
2022/09/08 09:08:02 HasParentFilePath duration: 0s, args: .git
2022/09/08 09:08:02 Flags duration: 0s, args: 
2022/09/08 09:08:02 debug: Pwd
~
2022/09/08 09:08:02 Pwd duration: 0s, args: 
2022/09/08 09:08:02 debug: Home
~
2022/09/08 09:08:02 GOOS duration: 0s, args: 
2022/09/08 09:08:02 ExecutionTime duration: 0s, args: 
2022/09/08 09:08:02 Flags duration: 0s, args: 
2022/09/08 09:08:02 debug: Pwd
~
2022/09/08 09:08:02 Pwd duration: 0s, args: 
2022/09/08 09:08:02 debug: Home
~
2022/09/08 09:08:02 GOOS duration: 0s, args: 
2022/09/08 09:08:02 ErrorCode duration: 0s, args: 
2022/09/08 09:08:02 TemplateCache duration: 0s, args: 
2022/09/08 09:08:02 TemplateCache duration: 0s, args: 
2022/09/08 09:08:02 Shell duration: 0s, args: 
2022/09/08 09:08:02 TemplateCache duration: 0s, args: 
2022/09/08 09:08:02 debug: Getenv
~\AppData\Local
2022/09/08 09:08:02 Getenv duration: 0s, args: LOCALAPPDATA
2022/09/08 09:08:02 CachePath duration: 503.7µs, args: 
2022/09/08 09:08:02 Flags duration: 0s, args:

@JanDeDobbeleer
Copy link
Owner

@brian6932 fzf is responsible for adjusting the layout again so I'm not yet convinced this bug is on our end. We don't do anything but print a string. We've seen this with git as well before, but it's always that executable which is ruining the ANSI rendering (or interpretation) due to unknown reasons

@brian6932
Copy link
Contributor Author

Well if you think that's the cause, I'll open an issue in https://github.com/kelleyma49/PSFzf as well

@brian6932 brian6932 mentioned this issue Sep 8, 2022
Open
@JanDeDobbeleer
Copy link
Owner

@brian6932 do you happen to have a transient prompt? If you, please comment out that part and reload the shell to see if it still occurs.

@brian6932
Copy link
Contributor Author

@JanDeDobbeleer nah I've disabled that

@lewis-yeung
Copy link
Contributor

It's probably a PSFzf related bug. I use only the fzf executable and don't get the bug.

@JanDeDobbeleer
Copy link
Owner

JanDeDobbeleer commented Sep 10, 2022 •
edited
Loading

Closing this as there's nothing we can do on our end.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2024

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues.
If you have found a problem that seems similar, please open a discussion first, complete the body with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JanDeDobbeleer JanDeDobbeleer

Labels
🐛 bug Something isn't working 🤔 info needed Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JanDeDobbeleer @brian6932 @lewis-yeung