Fixing type errors; mapquest currently only sends strings back from i…

…ts apis, not float values
kellydunn · May 5, 2015 · 9d0bf36 · 9d0bf36
1 parent e823924
commit 9d0bf36
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 19 deletions.
diff --git a/mapquest_geocoder.go b/mapquest_geocoder.go
@@ -7,16 +7,17 @@ import (
 	"io/ioutil"
 	"net/http"
 	"net/url"
+	"strconv"
 )
 
 // This struct contains all the funcitonality
 // of interacting with the MapQuest Geocoding Service
 type MapQuestGeocoder struct{}
 
 type mapQuestGeocodeResponse struct {
-	BoundingBox []float64 `json:"boundingbox"`
-	Lat         float64 
-	Lng         float64 `json:"lon"`
+	BoundingBox []string `json:"boundingbox"`
+	Lat         string 
+	Lng         string `json:"lon"`
 	DisplayName string  `json:"display_name"`
 }
 
@@ -79,16 +80,28 @@ func (g *MapQuestGeocoder) Geocode(query string) (*Point, error) {
 		return nil, err
 	}
 
+	fmt.Printf("%s", data)
+
 	res := []*mapQuestGeocodeResponse{}
 	json.Unmarshal(data, &res)
 
 	if len(res) == 0 {
 		return &Point{}, mapquestZeroResultsError
 	}
 
+	lat, err := strconv.ParseFloat(res[0].Lat, 64)
+	if err != nil {
+		return nil, err
+	}
+
+	lng, err := strconv.ParseFloat(res[0].Lng, 64)
+	if err != nil {
+		return nil, err
+	}	
+
 	p := &Point{
-		lat: res[0].Lat,
-		lng: res[0].Lng,
+		lat: lat,
+		lng: lng,
 	}
 
 	return p, nil

diff --git a/mapquest_geocoder_test.go b/mapquest_geocoder_test.go
@@ -25,7 +25,7 @@ func TestMapQuestGeocodeFromRequest(t *testing.T) {
 		t.Error("Unexecpected amount of results for mapquest mock response")
 	}
 
-	if res[0].Lat != 37.62181845 || res[0].Lng != -122.383992092462 {
-		t.Error(fmt.Sprintf("Expected: [37.62181845, -122.383992092462], Got: [%f, %f]", res[0].Lat, res[0].Lng))
+	if res[0].Lat != "37.62181845" || res[0].Lng != "-122.383992092462" {
+		t.Error(fmt.Sprintf("Expected: [37.62181845, -122.383992092462], Got: [%s, %s]", res[0].Lat, res[0].Lng))
 	}
 }
diff --git a/test/data/mapquest_geocode_success.json b/test/data/mapquest_geocode_success.json
@@ -5,13 +5,13 @@
     "osm_type": "way",
     "osm_id": "23718192",
     "boundingbox": [
-      37.6044343,
-      37.6392026,
-      -122.4026019,
-      -122.3549542
+      "37.6044343",
+      "37.6392026",
+      "-122.4026019",
+      "-122.3549542"
     ],
-    "lat": 37.62181845,
-    "lon": -122.383992092462,
+    "lat": "37.62181845",
+    "lon": "-122.383992092462",
     "display_name": "San Francisco International Airport, Walkway thru SFO Terminals, Millbrae, San Mateo County, California, 94128, United States of America",
     "class": "aeroway",
     "type": "aerodrome",
@@ -23,13 +23,13 @@
     "osm_type": "node",
     "osm_id": "1042081309",
     "boundingbox": [
-      -12.53305,
-      -12.53295,
-      -73.8000531,
-      -73.7999531
+      "-12.53305",
+      "-12.53295",
+      "-73.8000531",
+      "-73.7999531"
     ],
-    "lat": -12.533,
-    "lon": -73.8000031,
+    "lat": "-12.533",
+    "lon": "-73.8000031",
     "display_name": "San Francisco Airport, Pichari, La Convención, Department of Cusco, Peru",
     "class": "aeroway",
     "type": "aerodrome",