You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 28, 2023. It is now read-only.
@kellyselden this repo is a fantastic start in the right direction. Well done 👏 👏 👏 .
I'm not sure if you guys have already thought of this but it would be a lot more beneficial for addons to specify which files should be force included into the addon tree. In your example with ember-metrics, the app developer is required to know the structure of ember-metrics and which files are needed/dynamically imported which shouldnt really be the case.
Instead, there should me a new ember-cli hook in index.js to better support this which allows addon authors to generate the include collection. This would work hand in had with defined options in config/environment or ember-cli-build.js that addon consumers can specify (see ember-composable-helpers).
The text was updated successfully, but these errors were encountered:
and before what @offirgolan suggested become a thing, this addon should provide an option to output the paths (or names for clearer) of all eliminated modules.
@kellyselden this repo is a fantastic start in the right direction. Well done 👏 👏 👏 .
I'm not sure if you guys have already thought of this but it would be a lot more beneficial for addons to specify which files should be force included into the addon tree. In your example with ember-metrics, the app developer is required to know the structure of ember-metrics and which files are needed/dynamically imported which shouldnt really be the case.
Instead, there should me a new ember-cli hook in index.js to better support this which allows addon authors to generate the
include
collection. This would work hand in had with defined options in config/environment or ember-cli-build.js that addon consumers can specify (see ember-composable-helpers).The text was updated successfully, but these errors were encountered: