Skip to content
This repository has been archived by the owner on Oct 28, 2023. It is now read-only.

Support include in addons #15

Open
offirgolan opened this issue Dec 5, 2017 · 3 comments
Open

Support include in addons #15

offirgolan opened this issue Dec 5, 2017 · 3 comments

Comments

@offirgolan
Copy link

@kellyselden this repo is a fantastic start in the right direction. Well done 👏 👏 👏 .

I'm not sure if you guys have already thought of this but it would be a lot more beneficial for addons to specify which files should be force included into the addon tree. In your example with ember-metrics, the app developer is required to know the structure of ember-metrics and which files are needed/dynamically imported which shouldnt really be the case.

Instead, there should me a new ember-cli hook in index.js to better support this which allows addon authors to generate the include collection. This would work hand in had with defined options in config/environment or ember-cli-build.js that addon consumers can specify (see ember-composable-helpers).

@nightire
Copy link

nightire commented Dec 10, 2017

and before what @offirgolan suggested become a thing, this addon should provide an option to output the paths (or names for clearer) of all eliminated modules.

@kellyselden
Copy link
Owner

@nightire It does. It prints the dead modules to the console.

@nightire
Copy link

@kellyselden oh, yes, that's very helpful, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants