This repository has been archived by the owner on Feb 15, 2019. It is now read-only.
added dotted key export notation to to-js. #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great!. If you could squash your commits, I will merge ASAP. |
missing test added.
|
Thanks. |
|
Sorry I have to revert. There are a lot of failing tests, for some reason the CI wasn't failing. |
|
filed #59 |
|
I think I fixed the testing issue. Can you resubmit the PR after rebasing master please? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-i18n has dotted key definition along with nested object definition. https://github.com/jamesarosen/ember-i18n/wiki/Doc:-Defining-Translations
This request adds an option(--dotted) which allows dotted key export.