fix: fix failure artifacts in edge and firefox

They don't have getLogTypes.
kellyselden · Jan 13, 2023 · a9d442b · a9d442b
1 parent 3f77a41
commit a9d442b
Show file tree

Hide file tree

Showing 3 changed files with 70 additions and 13 deletions.
diff --git a/packages/mocha/src/failure-artifacts.js b/packages/mocha/src/failure-artifacts.js
@@ -57,23 +57,27 @@ async function failureArtifacts(outputDir) {
   let url = await this.browser.getUrl();
   await writeArtifact(`${title}.url.txt`, url);
 
-  let logTypes = await this.browser._browser.getLogTypes();
-  for (let logType of logTypes) {
-    let logs = await this.browser._browser.getLogs(logType);
-    let logsText = JSON.stringify(logs, null, 2);
-    await writeArtifact(`${title}.${logType}.txt`, logsText);
+  if (this.browser._browser.getLogTypes) {
+    let logTypes = await this.browser._browser.getLogTypes();
+    for (let logType of logTypes) {
+      let logs = await this.browser._browser.getLogs(logType);
+      let logsText = JSON.stringify(logs, null, 2);
+      await writeArtifact(`${title}.${logType}.txt`, logsText);
+    }
   }
 }
 
 async function flush() {
-  let logTypes = await this.browser._browser.getLogTypes();
-  for (let logType of logTypes) {
-    // https://v5.webdriver.io/docs/api/chromium.html#getlogs
-    // "Log buffer is reset after each request."
-    // For the failure logs to be useful, it should only include the failing test,
-    // not the whole test run up until the failure. So we need to clear the logs
-    // between each test.
-    await this.browser._browser.getLogs(logType);
+  if (this.browser._browser.getLogTypes) {
+    let logTypes = await this.browser._browser.getLogTypes();
+    for (let logType of logTypes) {
+      // https://v5.webdriver.io/docs/api/chromium.html#getlogs
+      // "Log buffer is reset after each request."
+      // For the failure logs to be useful, it should only include the failing test,
+      // not the whole test run up until the failure. So we need to clear the logs
+      // between each test.
+      await this.browser._browser.getLogs(logType);
+    }
   }
 }
 

diff --git a/packages/mocha/test/acceptance/index-test.js b/packages/mocha/test/acceptance/index-test.js
@@ -314,6 +314,38 @@ describe(function() {
         this.assertFilesExist('after without mocha-helpers !after all! hook for !failure');
       });
 
+      it('works in firefox', async function() {
+        let stats = await this.runTests({
+          filter: 'it firefox ',
+        });
+
+        expect(stats).matches(sinon.match({
+          tests: 2,
+          failures: 1,
+          passes: 1,
+        }));
+
+        this.extensions = ['png', 'html', 'url.txt'];
+
+        this.assertFilesExist('it firefox failure');
+      });
+
+      it('works in edge', async function() {
+        let stats = await this.runTests({
+          filter: 'it edge ',
+        });
+
+        expect(stats).matches(sinon.match({
+          tests: 2,
+          failures: 1,
+          passes: 1,
+        }));
+
+        this.extensions = ['png', 'html', 'url.txt'];
+
+        this.assertFilesExist('it edge failure');
+      });
+
       describe('retries', function() {
         const retries = 2;
 

diff --git a/packages/mocha/test/fixtures/failure-artifacts-test.js b/packages/mocha/test/fixtures/failure-artifacts-test.js
@@ -78,6 +78,27 @@ describe('failure artifacts', function() {
         assert.ok(this.test.currentRetry() === 2);
       });
     });
+
+    for (let browser of [
+      'firefox',
+      'edge',
+    ]) {
+      describe(browser, function() {
+        setUpWebDriver.call(this, {
+          overrides: {
+            browser,
+          },
+        });
+
+        it('failure', function() {
+          assert.ok(false);
+        });
+
+        it('success', function() {
+          assert.ok(true);
+        });
+      });
+    }
   });
 
   describe('beforeEach', function() {