This repository has been archived by the owner on Dec 1, 2018. It is now read-only.
Fix gke auth 1.3 #67
Merged
Fix gke auth 1.3 #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix authentication when config uses auth-provider to store the bearer token. This is the format in GKE with kubelet v1.3.
| try: | ||
| token = self.config.user['auth-provider']['config']['access-token'] | ||
| self._set_bearer_token(s, token) | ||
| except KeyError: |
There was a problem hiding this comment.
I am not a fan of this exception style. Could you adjust this to token = self.config["auth-provider"].get("config", {}).get("access-token") then setting the bearer token when token is not None. This IMO is cleaner and more explicit.
|
Thank you for your contribution! This is a great way to solve the GKE authentication issue when Pending the quick code change, I am going to merge this! |
Symmetric
force-pushed
the
fix-gke-auth-1.3
branch
from
9590538
to
91b0ca8
Compare
|
@brosner fixed -- LMK if you want me to squash these commits. |
|
Nice PR, i'm looking forward to seeing this merged! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: #65
Get the GKE auth token from the config map.