Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for encoding.BinaryUnmarshaler #101

Merged
merged 1 commit into from Mar 4, 2018
Merged

Add support for encoding.BinaryUnmarshaler #101

merged 1 commit into from Mar 4, 2018

Conversation

hypnoglow
Copy link
Contributor

Fixes #98 - url.URL implements encoding.BinaryUnmarshaler but not encoding.TextUnmarshaler (note馃)

@hypnoglow
Copy link
Contributor Author

Ah, url.URL implements encoding.BinaryUnmarshaler since 1.8.

@hypnoglow hypnoglow force-pushed the add-support-for-binaryunmarshaler branch 3 times, most recently from c2fd5a5 to 454329e Compare January 31, 2018 20:10
@hypnoglow hypnoglow force-pushed the add-support-for-binaryunmarshaler branch from 454329e to e79fdd6 Compare January 31, 2018 20:21
@hypnoglow
Copy link
Contributor Author

Fixed tests for url.URL by adding a build tag.

@teepark
Copy link
Collaborator

teepark commented Mar 4, 2018

Looks good, thanks @hypnoglow!

@teepark teepark merged commit dfd2ad3 into kelseyhightower:master Mar 4, 2018
@johanbrandhorst johanbrandhorst mentioned this pull request Jul 11, 2018
Closed
@ivanovaleksey
Copy link

Thanks for implementing this!
Maybe we could release a new version? It has been a long since v1.3.0.

@ivanovaleksey ivanovaleksey mentioned this pull request Sep 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hypnoglow @teepark @ivanovaleksey