Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asks users to activate TLC execution statistics #1

Closed
lemmy opened this issue Dec 3, 2019 · 7 comments
Closed

Asks users to activate TLC execution statistics #1

lemmy opened this issue Dec 3, 2019 · 7 comments

Comments

@lemmy
Copy link

lemmy commented Dec 3, 2019

The Toolbox asks users to activate execution statistics to guide TLC development (see screenshot below). Please add similar functionality to your extension. Technically, a file called esc.txt is dropped into ~/.tlaplus/ whose first line is either a random identifier, "RANDOM_IDENTIFIER", or "NO_STATISTICS" (see https://github.com/tlaplus/tlaplus/blob/master/tlatools/src/util/ExecutionStatisticsCollector.java).

Screenshot from 2019-10-21 13-18-55

Plaintext of the dialog's content is found online too: https://github.com/tlaplus/tlaplus/blob/master/tlatools/src/util/ExecutionStatisticsCollector.md. The statistics are publicly available: https://exec-stats.tlapl.us/tlaplus.csv. To report TLA+ Jupyter notebook as TLC's frontend, pass -Dtlc2.TLC.ide=tlaplus_jupyter as a Java system property.

@alygin VSCode extension will soon ask users to opt-in too.


Thanks for sharing TLA+ Jupyter notebooks with the community! I've already added your releases to the aggregator at http://wall.tlapl.us.

@kelvich
Copy link
Owner

kelvich commented Dec 4, 2019

Sure, will do.

kelvich added a commit that referenced this issue Dec 9, 2019
@kelvich
Copy link
Owner

kelvich commented Dec 9, 2019

#5

I've created --tlc-exec-stats install option which is set to share by default. Also added note about that behavior to README.md. Any other suggestions? May be change wording somewhere?

@lemmy
Copy link
Author

lemmy commented Dec 9, 2019

Have you tested this feature already? If yes, it seems as if it is broken because so far there have been no exec-stats for "tlaplus_jupyter" (d64477f#diff-8f9c6fbaedaf902848b1e9f9e47d60f2R253).

@kelvich
Copy link
Owner

kelvich commented Dec 9, 2019

I'm seeing my id (61a7f9a) now in tlaplus.csv now.
Does tla2tools v1.6.0 support tlc2.TLC.ide? I always download that version during install.

@lemmy
Copy link
Author

lemmy commented Dec 9, 2019

No, only recent nightlies report the value of tlc2.TLC.ide.

@kelvich
Copy link
Owner

kelvich commented Dec 9, 2019

Okay, I'll then switch download to https://nightly.tlapl.us/dist/tla2tools.jar

@lemmy
Copy link
Author

lemmy commented Dec 9, 2019

Great, but be aware of tlaplus/tlaplus#393 (comment)

kelvich added a commit that referenced this issue Sep 12, 2022
* share execution statistics #1

* fix 2.7 portability issues

* fix README wording

* set tlc2.TLC.ide in all calls to tla2tools
@kelvich kelvich closed this as completed Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants